3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-08-06 21:44:01 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Popup will now resize based on the implicitWidth/implicitHeight of it's children.

Browse source 
This causes a binding loop when using layouts like Column.

To resolve this the height/width of the popup in ExpandablePopup can now be set explicitly with contentWidth and contentHeight

For ExpandablePopups with contentItems that are not Layouts the implicitWidth/implicitHeight can be set directly in the contentItem.

CURA-8640
This commit is contained in:
j.delarago 2022-04-01 09:31:27 +02:00
parent 2c09c83896
commit cfad991120
5 changed files with 14 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

5
resources/qml/PrinterSelector/MachineSelector.qml
View file

@ -192,9 +192,8 @@ Cura.ExpandablePopup
contentItem: Item
{
id: popup
width: UM.Theme.getSize("machine_selector_widget_content").width
height: Math.min(machineSelectorList.contentHeight + separator.height + buttonRow.height, UM.Theme.getSize("machine_selector_widget_content").height) //Maximum height is the theme entry.
implicitWidth: UM.Theme.getSize("machine_selector_widget_content").width
implicitHeight: Math.min(machineSelectorList.contentHeight + separator.height + buttonRow.height, UM.Theme.getSize("machine_selector_widget_content").height) //Maximum height is the theme entry.
MachineSelectorList
{
id: machineSelectorList