From cf2252f4f9255ced5f8f5a9c45493013526d35d5 Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Fri, 2 Mar 2018 17:22:19 +0100 Subject: [PATCH] Simplify for loop in duplicateMaterial() --- cura/Machines/MaterialManager.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cura/Machines/MaterialManager.py b/cura/Machines/MaterialManager.py index 3665a9a423..ac2d8ed895 100644 --- a/cura/Machines/MaterialManager.py +++ b/cura/Machines/MaterialManager.py @@ -389,9 +389,6 @@ class MaterialManager(QObject): return None base_container = material_group.root_material_node.getContainer() - containers_to_copy = [] - for node in material_group.derived_material_node_list: - containers_to_copy.append(node.getContainer()) # Ensure all settings are saved. self._application.saveSettings() @@ -409,7 +406,8 @@ class MaterialManager(QObject): new_containers.append(new_base_container) # Clone all of them. - for container_to_copy in containers_to_copy: + for node in material_group.derived_material_node_list: + container_to_copy = node.getContainer() # Create unique IDs for every clone. new_id = new_base_id if container_to_copy.getMetaDataEntry("definition") != "fdmprinter":