3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-22 06:03:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

Merge pull request #17864 from Ultimaker/CURA-11480-setting-visibility-check-button

Browse source 
ppr setting was added when it should be excluded
This commit is contained in:
Casper Lamboo 2024-01-02 23:55:43 +01:00 • committed by GitHub
commit ce7e8ebf26
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
resources/qml/Preferences/SettingVisibilityPage.qml
View file

@ -123,7 +123,7 @@ UM.PreferencesPage
var idx = -1; var idx = -1;
for(var i = 0; i < settingVisibilityPresetsModel.items.length; ++i) for(var i = 0; i < settingVisibilityPresetsModel.items.length; ++i)
{ {
if(settingVisibilityPresetsModel.items[i].presetId == settingVisibilityPresetsModel.activePreset) if(settingVisibilityPresetsModel.items[i].presetId === settingVisibilityPresetsModel.activePreset)
{ {
idx = i; idx = i;
break; break;
@ -159,7 +159,7 @@ UM.PreferencesPage
id: definitionsModel id: definitionsModel
containerId: Cura.MachineManager.activeMachine != null ? Cura.MachineManager.activeMachine.definition.id: "" containerId: Cura.MachineManager.activeMachine != null ? Cura.MachineManager.activeMachine.definition.id: ""
showAll: true showAll: true
exclude: ["machine_settings", "command_line_settings"] exclude: ["machine_settings", "command_line_settings", "ppr"]
showAncestors: true showAncestors: true
expanded: ["*"] expanded: ["*"]
visibilityHandler: UM.SettingPreferenceVisibilityHandler {} visibilityHandler: UM.SettingPreferenceVisibilityHandler {}
@ -173,13 +173,13 @@ UM.PreferencesPage
id: loader id: loader
width: settingsListView.width - scrollBar.width width: settingsListView.width - scrollBar.width
height: model.type != undefined ? UM.Theme.getSize("section").height : 0 height: model.type !== undefined ? UM.Theme.getSize("section").height : 0
property var definition: model property var definition: model
property var settingDefinitionsModel: definitionsModel property var settingDefinitionsModel: definitionsModel
asynchronous: true asynchronous: true
active: model.type != undefined active: model.type !== undefined
sourceComponent: sourceComponent:
{ {
switch (model.type) switch (model.type)