Apply suggestions from code review

Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
This commit is contained in:
Joey de l'Arago 2022-12-05 14:42:35 +01:00 committed by GitHub
parent 741a112282
commit ce5691c12d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 28 additions and 15 deletions

View file

@ -68,7 +68,10 @@ Item
}
visible: currentModeIndex == PrintSetupSelectorContents.Mode.Recommended
function onModeChanged() { currentModeIndex = PrintSetupSelectorContents.Mode.Custom }
function onModeChanged()
{
currentModeIndex = PrintSetupSelectorContents.Mode.Custom;
}
}
CustomPrintSetup
@ -125,7 +128,8 @@ Item
{
id: buttonRow
property real padding: UM.Theme.getSize("default_margin").width
height: {
height:
{
if (currentModeIndex == PrintSetupSelectorContents.Mode.Custom)
{
return recommendedButton.height + 2 * padding + (draggableArea.visible ? draggableArea.height : 0)