From f4bfe915e1e12dabefa3acab9a399963b73b6d0e Mon Sep 17 00:00:00 2001 From: Jelle Spijker Date: Fri, 6 Jan 2023 13:56:53 +0100 Subject: [PATCH 1/3] msi input as a string --- .github/workflows/cura-all-installers.yml | 10 +++++----- .github/workflows/cura-installer.yml | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cura-all-installers.yml b/.github/workflows/cura-all-installers.yml index cf737f810b..5c7a5b2e63 100644 --- a/.github/workflows/cura-all-installers.yml +++ b/.github/workflows/cura-all-installers.yml @@ -72,7 +72,7 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: false + msi: 'false' secrets: inherit windows-installer-create-msi: @@ -87,7 +87,7 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: true + msi: 'true' secrets: inherit linux-installer-create: @@ -102,7 +102,7 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: false + msi: 'false' secrets: inherit linux-modern-installer-create: @@ -117,7 +117,7 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: false + msi: 'false' secrets: inherit macos-installer-create: @@ -132,5 +132,5 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: false + msi: 'false' secrets: inherit diff --git a/.github/workflows/cura-installer.yml b/.github/workflows/cura-installer.yml index c42d781da6..fb8a6e08fb 100644 --- a/.github/workflows/cura-installer.yml +++ b/.github/workflows/cura-installer.yml @@ -47,8 +47,8 @@ on: msi: description: 'Create the msi' default: false - required: true - type: boolean + required: 'true' + type: string env: CONAN_LOGIN_USERNAME_CURA: ${{ secrets.CONAN_USER }} From 6a79fc6d371781145dccaa57400dfdcda7f89c9c Mon Sep 17 00:00:00 2001 From: Jelle Spijker Date: Fri, 6 Jan 2023 14:00:25 +0100 Subject: [PATCH 2/3] remove quotes --- .github/workflows/cura-all-installers.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/cura-all-installers.yml b/.github/workflows/cura-all-installers.yml index 5c7a5b2e63..cf737f810b 100644 --- a/.github/workflows/cura-all-installers.yml +++ b/.github/workflows/cura-all-installers.yml @@ -72,7 +72,7 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: 'false' + msi: false secrets: inherit windows-installer-create-msi: @@ -87,7 +87,7 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: 'true' + msi: true secrets: inherit linux-installer-create: @@ -102,7 +102,7 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: 'false' + msi: false secrets: inherit linux-modern-installer-create: @@ -117,7 +117,7 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: 'false' + msi: false secrets: inherit macos-installer-create: @@ -132,5 +132,5 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: 'false' + msi: false secrets: inherit From beac5b7eb1bce15da89af96b17ef51e469a6db17 Mon Sep 17 00:00:00 2001 From: Jelle Spijker Date: Fri, 6 Jan 2023 14:01:35 +0100 Subject: [PATCH 3/3] fix wrong quote placement --- .github/workflows/cura-installer.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cura-installer.yml b/.github/workflows/cura-installer.yml index fb8a6e08fb..69dc0dedb3 100644 --- a/.github/workflows/cura-installer.yml +++ b/.github/workflows/cura-installer.yml @@ -46,8 +46,8 @@ on: type: boolean msi: description: 'Create the msi' - default: false - required: 'true' + default: 'false' + required: true type: string env: