3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2026-01-24 22:17:28 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Remove useless code

Browse source 
The resolve properties on the QML objects cause a crash in PyQt. They are not the actual cause, because this should work anyway. But for now, they are however completely useless because the material bed temperature setting can't have a resolve function, so we can remove them anyway.

CURA-11657
This commit is contained in:
Erwan MATHIEU 2024-03-06 16:00:38 +01:00
parent 85a7586b76
commit cd8c5029d2
3 changed files with 1 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
resources/qml/PrintMonitor.qml
View file

@ -132,8 +132,6 @@ ScrollView
key: "material_bed_temperature"
watchedProperties: ["value", "minimum_value", "maximum_value", "resolve"]
storeIndex: 0
property var resolve: Cura.MachineManager.activeStack != Cura.MachineManager.activeMachine ? properties.resolve : "None"
}
UM.SettingPropertyProvider

2
resources/qml/PrinterOutput/ExtruderBox.qml
View file

@ -25,8 +25,6 @@ Item
key: "material_print_temperature"
watchedProperties: ["value", "minimum_value", "maximum_value", "resolve"]
storeIndex: 0
property var resolve: Cura.MachineManager.activeStack != Cura.MachineManager.activeMachine ? properties.resolve : "None"
}
Rectangle

12
resources/qml/PrinterOutput/HeatedBedBox.qml
View file

@ -199,17 +199,7 @@ Item
{
return "";
}
if ((bedTemperature.resolve != "None" && bedTemperature.resolve) && (bedTemperature.stackLevels[0] != 0) && (bedTemperature.stackLevels[0] != 1))
{
// We have a resolve function. Indicates that the setting is not settable per extruder and that
// we have to choose between the resolved value (default) and the global value
// (if user has explicitly set this).
return bedTemperature.resolve;
}
else
{
return bedTemperature.properties.value;
}
return bedTemperature.properties.value;
}
}
}