From bcb88981b7947af86e603ec26f8920453c11f29c Mon Sep 17 00:00:00 2001 From: Remco Burema Date: Tue, 8 Nov 2022 18:00:44 +0100 Subject: [PATCH 1/2] Add support interface wall count settings. part of CURA-9350 --- resources/definitions/fdmprinter.def.json | 48 +++++++++++++++++++++++ resources/setting_visibility/expert.cfg | 3 ++ 2 files changed, 51 insertions(+) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 08a895c9fa..eab18dd00d 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -4682,6 +4682,54 @@ "settable_per_mesh": false, "settable_per_extruder": true }, + "support_interface_wall_count": + { + "label": "Support Interface Wall Line Count", + "description": "The number of walls with which to surround support interface. Adding a wall can make support print more reliably and can support overhangs better, but increases print time and material used.", + "default_value": 0, + "minimum_value": "0", + "minimum_value_warning": "0", + "maximum_value_warning": "0 if (support_skip_some_zags and support_interface_pattern == 'zigzag') else 3", + "maximum_value": "999999", + "type": "int", + "value": "1 if (support_interface_pattern == 'zigzag') else 0", + "enabled": "support_interface_enable or support_meshes_present", + "limit_to_extruder": "support_interface_extruder_nr", + "settable_per_mesh": false, + "settable_per_extruder": true, + "children": { + "support_roof_wall_count": { + "label": "Support Roof Wall Line Count", + "description": "The number of walls with which to surround support interface roof. Adding a wall can make support print more reliably and can support overhangs better, but increases print time and material used.", + "default_value": 0, + "minimum_value": "0", + "minimum_value_warning": "0", + "maximum_value_warning": "0 if (support_skip_some_zags and support_interface_pattern == 'zigzag') else 3", + "maximum_value": "999999", + "type": "int", + "value": "1 if (support_interface_pattern == 'zigzag') else 0", + "enabled": "support_interface_enable or support_meshes_present", + "limit_to_extruder": "support_interface_extruder_nr", + "settable_per_mesh": false, + "settable_per_extruder": true + }, + "support_bottom_wall_count": { + "label": "Support Bottom Wall Line Count", + "description": "The number of walls with which to surround support interface floor. Adding a wall can make support print more reliably and can support overhangs better, but increases print time and material used.", + "default_value": 0, + "minimum_value": "0", + "minimum_value_warning": "0", + "maximum_value_warning": "0 if (support_skip_some_zags and support_interface_pattern == 'zigzag') else 3", + "maximum_value": "999999", + "type": "int", + "value": "1 if (support_interface_pattern == 'zigzag') else 0", + "enabled": "support_interface_enable or support_meshes_present", + "limit_to_extruder": "support_interface_extruder_nr", + "settable_per_mesh": false, + "settable_per_extruder": true + } + } + }, "zig_zaggify_support": { "label": "Connect Support Lines", diff --git a/resources/setting_visibility/expert.cfg b/resources/setting_visibility/expert.cfg index 66a26d5466..b7aaeeeaa2 100644 --- a/resources/setting_visibility/expert.cfg +++ b/resources/setting_visibility/expert.cfg @@ -277,6 +277,9 @@ minimum_support_area support_interface_enable support_roof_enable support_bottom_enable +support_interface_wall_count +support_roof_wall_count +support_bottom_wall_count support_interface_height support_roof_height support_bottom_height From c23b019f169a2fd9e85fa8d2b5c040f6abcc5ecc Mon Sep 17 00:00:00 2001 From: Remco Burema Date: Wed, 9 Nov 2022 15:23:00 +0100 Subject: [PATCH 2/2] Couple support roof/floor wall-count to parent setting by default. part of CURA-9350 --- resources/definitions/fdmprinter.def.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index eab18dd00d..5c82d04d61 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -4707,7 +4707,7 @@ "maximum_value_warning": "0 if (support_skip_some_zags and support_interface_pattern == 'zigzag') else 3", "maximum_value": "999999", "type": "int", - "value": "1 if (support_interface_pattern == 'zigzag') else 0", + "value": "support_interface_wall_count", "enabled": "support_interface_enable or support_meshes_present", "limit_to_extruder": "support_interface_extruder_nr", "settable_per_mesh": false, @@ -4722,7 +4722,7 @@ "maximum_value_warning": "0 if (support_skip_some_zags and support_interface_pattern == 'zigzag') else 3", "maximum_value": "999999", "type": "int", - "value": "1 if (support_interface_pattern == 'zigzag') else 0", + "value": "support_interface_wall_count", "enabled": "support_interface_enable or support_meshes_present", "limit_to_extruder": "support_interface_extruder_nr", "settable_per_mesh": false,