Remove Alternate Skin Rotations setting

It's been replaced completely by the Top/Bottom Line Directions setting.

plugins/VersionUpgrade/VersionUpgrade43to44/VersionUpgrade43to44.py

@@ -2,6 +2,7 @@ import configparser
 from typing import Tuple, List
 import io
 from UM.VersionUpgrade import VersionUpgrade
+from UM.Util import parseBool  # To parse whether the Alternate Skin Rotations function is activated.
 
 _renamed_container_id_map = {
     "ultimaker2_0.25": "ultimaker2_olsson_0.25",
@@ -61,6 +62,11 @@ class VersionUpgrade43to44(VersionUpgrade):
         if parser["metadata"].get("type", "") == "quality_changes":
             parser["metadata"]["intent_category"] = "default"
 
+        if "values" in parser:
+            # Alternate skin rotation should be translated to top/bottom line directions.
+            if "skin_alternate_rotation" in parser["values"] and parseBool(parser["values"]["skin_alternate_rotation"]):
+                parser["skin_angles"] = "[45, 135, 0, 90]"
+
         result = io.StringIO()
         parser.write(result)
         return [filename], [result.getvalue()]

resources/definitions/fdmprinter.def.json

@@ -6441,16 +6441,6 @@
                     "settable_per_mesh": false,
                     "settable_per_extruder": true
                 },
-                "skin_alternate_rotation":
-                {
-                    "label": "Alternate Skin Rotation",
-                    "description": "Alternate the direction in which the top/bottom layers are printed. Normally they are printed diagonally only. This setting adds the X-only and Y-only directions.",
-                    "type": "bool",
-                    "default_value": false,
-                    "enabled": "(top_layers > 0 or bottom_layers > 0) and top_bottom_pattern != 'concentric'",
-                    "limit_to_extruder": "top_bottom_extruder_nr",
-                    "settable_per_mesh": true
-                },
                 "cross_infill_pocket_size":
                 {
                     "label": "Cross 3D Pocket Size",

resources/setting_visibility/expert.cfg

@@ -372,7 +372,6 @@ coasting_enable
 coasting_volume
 coasting_min_volume
 coasting_speed
-skin_alternate_rotation
 cross_infill_pocket_size
 spaghetti_infill_enabled
 spaghetti_infill_stepped