3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-23 06:33:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Only call failed_callback if provided

Browse source 
Otherwise we'd crash because NoneType can't be called.

Contributes to issue CURA-8539.
This commit is contained in:
Ghostkeeper 2021-11-22 11:59:23 +01:00
parent f0cbdeb903
commit c36863da56
No known key found for this signature in database
GPG key ID: D2A8871EE34EC59A
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cura/OAuth2/AuthorizationHelpers.py
View file

@ -132,20 +132,23 @@ class AuthorizationHelpers:
""" """
if reply.error() != QNetworkReply.NetworkError.NoError: if reply.error() != QNetworkReply.NetworkError.NoError:
Logger.warning(f"Could not access account information. QNetworkError {reply.errorString()}") Logger.warning(f"Could not access account information. QNetworkError {reply.errorString()}")
failed_callback() if failed_callback is not None:
failed_callback()
return return
profile_data = HttpRequestManager.getInstance().readJSON(reply) profile_data = HttpRequestManager.getInstance().readJSON(reply)
if profile_data is None or "data" not in profile_data: if profile_data is None or "data" not in profile_data:
Logger.warning("Could not parse user data from token.") Logger.warning("Could not parse user data from token.")
failed_callback() if failed_callback is not None:
failed_callback()
return return
profile_data = profile_data["data"] profile_data = profile_data["data"]
required_fields = {"user_id", "username"} required_fields = {"user_id", "username"}
if "user_id" not in profile_data or "username" not in profile_data: if "user_id" not in profile_data or "username" not in profile_data:
Logger.warning(f"User data missing required field(s): {required_fields - set(profile_data.keys())}") Logger.warning(f"User data missing required field(s): {required_fields - set(profile_data.keys())}")
failed_callback() if failed_callback is not None:
failed_callback()
return return
success_callback(UserProfile( success_callback(UserProfile(