3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-08-09 06:45:09 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Don't modify original dict while iterating over it

Browse source 
Just store the results in a new dict and return that one.
This commit is contained in:
Ghostkeeper 2016-09-15 12:45:20 +02:00
parent b914aefac6
commit c223044541
No known key found for this signature in database
GPG key ID: 701948C5954A7385
1 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
plugins/VersionUpgrade/VersionUpgrade21to22/VersionUpgrade21to22.py
View file

@ -390,17 +390,20 @@ class VersionUpgrade21to22(VersionUpgrade):
# \return The same dictionary.
@staticmethod
def translateSettings(settings):
new_settings = {}
for key, value in settings.items():
if key in _removed_settings:
del settings[key]
elif key == "retraction_combing": #Combing was made into an enum instead of a boolean.
settings[key] = "off" if (value == "False") else "all"
elif key in _setting_name_translations:
del settings[key]
settings[_setting_name_translations[key]] = value
continue
if key == "retraction_combing": #Combing was made into an enum instead of a boolean.
new_settings[key] = "off" if (value == "False") else "all"
continue
if key in _setting_name_translations:
new_settings[_setting_name_translations[key]] = value
continue
new_settings[key] = value
if "infill_overlap" in settings: # New setting, added in 2.3
settings["skin_overlap"] = settings["infill_overlap"]
return settings
new_settings["skin_overlap"] = settings["infill_overlap"]
return new_settings
## Translates a setting name for the change from Cura 2.1 to 2.2.
#