3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 06:57:28 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Remove unnecessary if checks

Browse source 
CURA-4048
This commit is contained in:
Lipu Fei 2017-07-27 09:54:28 +02:00
parent 9fca677d40
commit c16bfa8949
1 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
plugins/CuraEngineBackend/CuraEngineBackend.py
View file

@ -619,9 +619,8 @@ class CuraEngineBackend(QObject, Backend):
self._global_container_stack.containersChanged.disconnect(self._onChanged) self._global_container_stack.containersChanged.disconnect(self._onChanged)
extruders = list(ExtruderManager.getInstance().getMachineExtruders(self._global_container_stack.getId())) extruders = list(ExtruderManager.getInstance().getMachineExtruders(self._global_container_stack.getId()))
if extruders: for extruder in extruders:
for extruder in extruders: extruder.propertyChanged.disconnect(self._onSettingChanged)
extruder.propertyChanged.disconnect(self._onSettingChanged)
self._global_container_stack = Application.getInstance().getGlobalContainerStack() self._global_container_stack = Application.getInstance().getGlobalContainerStack()
@ -629,9 +628,8 @@ class CuraEngineBackend(QObject, Backend):
self._global_container_stack.propertyChanged.connect(self._onSettingChanged) # Note: Only starts slicing when the value changed. self._global_container_stack.propertyChanged.connect(self._onSettingChanged) # Note: Only starts slicing when the value changed.
self._global_container_stack.containersChanged.connect(self._onChanged) self._global_container_stack.containersChanged.connect(self._onChanged)
extruders = list(ExtruderManager.getInstance().getMachineExtruders(self._global_container_stack.getId())) extruders = list(ExtruderManager.getInstance().getMachineExtruders(self._global_container_stack.getId()))
if extruders: for extruder in extruders:
for extruder in extruders: extruder.propertyChanged.connect(self._onSettingChanged)
extruder.propertyChanged.connect(self._onSettingChanged)
self._onActiveExtruderChanged() self._onActiveExtruderChanged()
self._onChanged() self._onChanged()
@ -640,9 +638,8 @@ class CuraEngineBackend(QObject, Backend):
# Connect all extruders of the active machine. This might cause a few connects that have already happend, # Connect all extruders of the active machine. This might cause a few connects that have already happend,
# but that shouldn't cause issues as only new / unique connections are added. # but that shouldn't cause issues as only new / unique connections are added.
extruders = list(ExtruderManager.getInstance().getMachineExtruders(self._global_container_stack.getId())) extruders = list(ExtruderManager.getInstance().getMachineExtruders(self._global_container_stack.getId()))
if extruders: for extruder in extruders:
for extruder in extruders: extruder.propertyChanged.connect(self._onSettingChanged)
extruder.propertyChanged.connect(self._onSettingChanged)
if self._active_extruder_stack: if self._active_extruder_stack:
self._active_extruder_stack.containersChanged.disconnect(self._onChanged) self._active_extruder_stack.containersChanged.disconnect(self._onChanged)