From c0561bc5255227d3585a0cd554de6cdd45a37233 Mon Sep 17 00:00:00 2001 From: Ian Paschal Date: Tue, 13 Feb 2018 15:50:29 +0100 Subject: [PATCH] CURA-4935 Can't disable sending anonymous slice data and checking updates This is the ~5 minute~ 3 second fix. I know it's not the more proper way to do it, but I've spent several hours on the more proper way to do it and it's causing huge amounts of headache (because, for example, the PluginBrowser installs plugins and the PluginRegistry removes them, and the PluginBrowser can't update the PluginsModel because the PluginsModel is intantiated in QML instead of in `PluginBrowser.py`, etc. etc. etc. I'm effectively doing a full refactor of this functionality while simultaneously avoiding moving any "install from remote URL" functionality into the PluginRegistry which is dumb. I'd prefer a simple, stable soution now instead of re-writing this all again. I'll make a proposal for a proper, organized refactor for Cookies & Cura. --- plugins/PluginBrowser/PluginBrowser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/PluginBrowser/PluginBrowser.py b/plugins/PluginBrowser/PluginBrowser.py index 0e6992c51d..c8a5e1e545 100644 --- a/plugins/PluginBrowser/PluginBrowser.py +++ b/plugins/PluginBrowser/PluginBrowser.py @@ -287,7 +287,7 @@ class PluginBrowser(QObject, Extension): @pyqtProperty(QObject, notify=pluginsMetadataChanged) def pluginsModel(self): - self._plugins_model = PluginsModel(self._view) + self._plugins_model = PluginsModel(None, self._view) # self._plugins_model.update() # Check each plugin the registry for matching plugin from server