3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-10 08:17:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Multipart data objects used for posting new materials are now deleted upon completion

Browse source 
CURA-344
This commit is contained in:
Jaime van Kessel 2016-06-30 14:56:36 +02:00
parent ca79e398c8
commit bfc7a7e3c9
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
NetworkPrinterOutputDevice.py
View file

@ -353,11 +353,10 @@ class NetworkPrinterOutputDevice(PrinterOutputDevice):
material_multi_part.append(material_part) material_multi_part.append(material_part)
url = QUrl("http://" + self._address + self._api_prefix + "materials") url = QUrl("http://" + self._address + self._api_prefix + "materials")
material_post_request = QNetworkRequest(url) material_post_request = QNetworkRequest(url)
reply = self._manager.post(material_post_request, material_multi_part)
self._manager.post(material_post_request, material_multi_part) # Keep reference to material_part, material_multi_part and reply so the garbage collector won't touch them.
self._material_post_objects[id(reply)] = (material_part, material_multi_part, reply)
# Keep reference to material_part and material_multi_part so the garbage collector won't touch them.
self._material_post_objects[container.getId()] = (material_part, material_multi_part)
except NotImplementedError: except NotImplementedError:
# If the material container is not the most "generic" one it can't be serialized an will raise a # If the material container is not the most "generic" one it can't be serialized an will raise a
# NotImplementedError. We can simply ignore these. # NotImplementedError. We can simply ignore these.
@ -441,8 +440,8 @@ class NetworkPrinterOutputDevice(PrinterOutputDevice):
# Check if the authentication is accepted. # Check if the authentication is accepted.
self._checkAuthentication() self._checkAuthentication()
elif "materials" in reply.url().toString(): elif "materials" in reply.url().toString():
# TODO: Remove cached post request items. # Remove cached post request items.
pass del self._material_post_objects[id(reply)]
else: else:
reply.uploadProgress.disconnect(self._onUploadProgress) reply.uploadProgress.disconnect(self._onUploadProgress)
self._progress_message.hide() self._progress_message.hide()