3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix check of model checker to take new unit of shrinkage factor into account

Browse source 
It's now based around 100%, so this should be adjusted.

Contributes to issue CURA-7118.
This commit is contained in:
Ghostkeeper 2020-09-02 01:02:12 +02:00
parent af03bc8f24
commit bd074bf753
No known key found for this signature in database
GPG key ID: D2A8871EE34EC59A
1 changed files with 5 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

18
plugins/ModelChecker/ModelChecker.py
View file

@ -58,7 +58,7 @@ class ModelChecker(QObject, Extension):
self._createView()
def checkObjectsForShrinkage(self):
shrinkage_threshold = 0.5 #From what shrinkage percentage a warning will be issued about the model size.
shrinkage_threshold = 100.5 #From what shrinkage percentage a warning will be issued about the model size.
warning_size_xy = 150 #The horizontal size of a model that would be too large when dealing with shrinking materials.
warning_size_z = 100 #The vertical size of a model that would be too large when dealing with shrinking materials.
@ -86,7 +86,7 @@ class ModelChecker(QObject, Extension):
Application.getInstance().callLater(lambda: self.onChanged.emit())
return False
if material_shrinkage[node_extruder_position] > shrinkage_threshold:
if material_shrinkage > shrinkage_threshold:
bbox = node.getBoundingBox()
if bbox is not None and (bbox.width >= warning_size_xy or bbox.depth >= warning_size_xy or bbox.height >= warning_size_z):
warning_nodes.append(node)
@ -134,16 +134,8 @@ class ModelChecker(QObject, Extension):
def showWarnings(self):
self._caution_message.show()
def _getMaterialShrinkage(self):
def _getMaterialShrinkage(self) -> float:
global_container_stack = Application.getInstance().getGlobalContainerStack()
if global_container_stack is None:
return {}
material_shrinkage = {}
# Get all shrinkage values of materials used
for extruder_position, extruder in enumerate(global_container_stack.extruderList):
shrinkage = extruder.material.getProperty("material_shrinkage_percentage", "value")
if shrinkage is None:
shrinkage = 0
material_shrinkage[str(extruder_position)] = shrinkage
return material_shrinkage
return 100
return global_container_stack.getProperty("material_shrinkage_percentage", "value")