3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-15 02:37:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Don't use MockContainer in hasUserChanges tests

Browse source 
This makes the testing code much simpler.

Contributes to issue CURA-3497.
This commit is contained in:
Ghostkeeper 2017-04-11 17:12:43 +02:00
parent e0c8a52eec
commit bbddc2308e
No known key found for this signature in database
GPG key ID: C5F96EE2BC0F7E75
1 changed files with 10 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

26
tests/Settings/TestGlobalStack.py
View file

@ -452,31 +452,25 @@ def test_getPropertyInstancesBeforeResolve(global_stack):
## Tests whether the hasUserValue returns true for settings that are changed in ## Tests whether the hasUserValue returns true for settings that are changed in
# the user-changes container. # the user-changes container.
def test_hasUserValueUserChanges(global_stack): def test_hasUserValueUserChanges(global_stack):
user_changes = MockContainer("test_user_changes", "user") container = unittest.mock.MagicMock()
container.getMetaDataEntry = unittest.mock.MagicMock(return_value = "user")
container.hasProperty = lambda key, property: key == "layer_height" #Only have the layer_height property set.
global_stack.userChanges = container
def hasProperty(key, property):
return key == "layer_height" and property == "value" # Only have the layer_height property set.
user_changes.hasProperty = hasProperty
global_stack.userChanges = user_changes
assert not global_stack.hasUserValue("infill_sparse_density")
assert global_stack.hasUserValue("layer_height") assert global_stack.hasUserValue("layer_height")
assert not global_stack.hasUserValue("infill_sparse_density")
assert not global_stack.hasUserValue("") assert not global_stack.hasUserValue("")
## Tests whether the hasUserValue returns true for settings that are changed in ## Tests whether the hasUserValue returns true for settings that are changed in
# the quality-changes container. # the quality-changes container.
def test_hasUserValueQualityChanges(global_stack): def test_hasUserValueQualityChanges(global_stack):
quality_changes = MockContainer("test_quality_changes", "quality_changes") container = unittest.mock.MagicMock()
container.getMetaDataEntry = unittest.mock.MagicMock(return_value = "quality_changes")
container.hasProperty = lambda key, property: key == "layer_height" #Only have the layer_height property set.
global_stack.qualityChanges = container
def hasProperty(key, property):
return key == "layer_height" and property == "value" # Only have the layer_height property set.
quality_changes.hasProperty = hasProperty
global_stack.qualityChanges = quality_changes
assert not global_stack.hasUserValue("infill_sparse_density")
assert global_stack.hasUserValue("layer_height") assert global_stack.hasUserValue("layer_height")
assert not global_stack.hasUserValue("infill_sparse_density")
assert not global_stack.hasUserValue("") assert not global_stack.hasUserValue("")
## Tests whether inserting a container is properly forbidden. ## Tests whether inserting a container is properly forbidden.