From c332c7debcb1616d3dd089595837b9eee6a1577e Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Fri, 25 Oct 2019 13:02:19 +0200 Subject: [PATCH 1/6] Improve issue templates Two major changes here: 1. No longer include the instructions in comments. Quite often the filled in template was also in comments then because people don't know the HTML formatting. Also if the template is not completely filled in now, public shaming ensues. 2. The reproduce steps for bugs now suggest a numbered list of steps. Hopefully this will improve the bug reports we get with better reproduction steps. --- .github/ISSUE_TEMPLATE.md | 23 ++++++++++++----------- .github/ISSUE_TEMPLATE/bug-report.md | 15 ++++++++------- .github/ISSUE_TEMPLATE/feature_request.md | 11 ++++++----- 3 files changed, 26 insertions(+), 23 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 2f880a9e32..8e56787aeb 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -11,23 +11,24 @@ Information about how to find the log file can be found at https://github.com/Ul Thank you for using Cura! --> -**Application Version** - +**Application version** +(The version of the application this issue occurs with.) **Platform** - +(Information about the operating system the issue occurs on. Include at least the operating system. In the case of visual glitches/issues, also include information about your graphics drivers and GPU.) **Printer** - +(Which printer was selected in Cura? If possible, please attach project file as .curaproject.3mf.zip.) -**Steps to Reproduce** - +**Reproduction steps** +1. Something you did. +2. Something you did next. -**Actual Results** - +**Actual results** +(What happens after the above steps have been followed.) **Expected results** - +(What should happen after the above steps have been followed.) -**Additional Information** - +**Additional information** +(Extra information relevant to the issue, like screenshots. Don't forget to attach the log files with this issue report.) diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md index a7371e02a6..749b8037c1 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.md +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -22,22 +22,23 @@ Thank you for using Cura! --> **Application version** - +(The version of the application this issue occurs with.) **Platform** - +(Information about the operating system the issue occurs on. Include at least the operating system. In the case of visual glitches/issues, also include information about your graphics drivers and GPU.) **Printer** - +(Which printer was selected in Cura? If possible, please attach project file as .curaproject.3mf.zip.) **Reproduction steps** - +1. Something you did. +2. Something you did next. **Actual results** - +(What happens after the above steps have been followed.) **Expected results** - +(What should happen after the above steps have been followed.) **Additional information** - +(Extra information relevant to the issue, like screenshots. Don't forget to attach the log files with this issue report.) diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 2a0a3e4e7b..a10d664a04 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -8,15 +8,16 @@ assignees: '' --- **Is your feature request related to a problem? Please describe.** - +(A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]) **Describe the solution you'd like** - +(A clear and concise description of what you want to happen. If possible, describe why you think this is a good solution.) **Describe alternatives you've considered** - +(A clear and concise description of any alternative solutions or features you've considered. Again, if possible, think about why these alternatives are not working out.) **Affected users and/or printers** - +(Who do you think will benefit from this? Is everyone going to benefit from these changes? Or specific kinds of users?) + **Additional context** - +(Add any other context or screenshots about the feature request here.) From 2abb9842d2ed75ca587fb7ed980bc5b7154f63a8 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Fri, 25 Oct 2019 13:21:18 +0200 Subject: [PATCH 2/6] Choose a supported quality as preferred quality One that is supported by the preferred material and nozzle. As discussed in #6474. --- resources/definitions/strateo3d.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/strateo3d.def.json b/resources/definitions/strateo3d.def.json index 4bf4e19aa4..2ee3650404 100644 --- a/resources/definitions/strateo3d.def.json +++ b/resources/definitions/strateo3d.def.json @@ -14,7 +14,7 @@ "has_variants": true, "preferred_variant_name": "Standard 0.6", "preferred_material": "emotiontech_pla", - "preferred_quality_type": "e", + "preferred_quality_type": "c", "variants_name": "Print Head", "machine_extruder_trains": { From 0168a1d5e0fe3b395952fac673d16f7f9a0a22e3 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Fri, 25 Oct 2019 14:12:55 +0200 Subject: [PATCH 3/6] Don't output to stderr if there is no stderr This can happen on Windows where the default command line doesn't have a stderr channel. Put it in stdout then. Fixes #6579. --- cura_app.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cura_app.py b/cura_app.py index 080479ee92..e14b4410bc 100755 --- a/cura_app.py +++ b/cura_app.py @@ -1,6 +1,6 @@ #!/usr/bin/env python3 -# Copyright (c) 2018 Ultimaker B.V. +# Copyright (c) 2019 Ultimaker B.V. # Cura is released under the terms of the LGPLv3 or higher. import argparse @@ -131,7 +131,10 @@ def exceptHook(hook_type, value, traceback): # Set exception hook to use the crash dialog handler sys.excepthook = exceptHook # Enable dumping traceback for all threads -faulthandler.enable(all_threads = True) +if sys.stderr: + faulthandler.enable(file = sys.stderr, all_threads = True) +else: + faulthandler.enable(file = sys.stdout, all_threads = True) # Workaround for a race condition on certain systems where there # is a race condition between Arcus and PyQt. Importing Arcus From 11d30dab56ce8d295b2aaa7ca4aa9585708ee69d Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Fri, 25 Oct 2019 23:21:30 +0200 Subject: [PATCH 4/6] Improve setting descriptions for flow rate compensation settings The original setting descriptions were wholly undescriptive... Done during investigation of these settings for the Setting Guide. --- resources/definitions/fdmprinter.def.json | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index ca0057adb4..cd847ef8b6 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6658,30 +6658,26 @@ }, "flow_rate_max_extrusion_offset": { - "label": "Flow rate compensation max extrusion offset", - "description": "The maximum distance in mm to compensate.", + "label": "Flow Rate Compensation Max Extrusion Offset", + "description": "The maximum distance in mm to move the filament to compensate for changes in flow rate.", "unit": "mm", "type": "float", "minimum_value": "0", "maximum_value_warning": "10", "default_value": 0, - "value": "0", - "enabled": true, "settable_per_mesh": false, "settable_per_extruder": false, "settable_per_meshgroup": false }, "flow_rate_extrusion_offset_factor": { - "label": "Flow rate compensation factor", - "description": "The multiplication factor for the flow rate -> distance translation.", + "label": "Flow Rate Compensation Factor", + "description": "How far to move the filament in order to compensate for changes in flow rate, as a percentage of how far the filament would move in one second of extrusion.", "unit": "%", "type": "float", "minimum_value": "0", "maximum_value_warning": "100", "default_value": 100, - "value": "100", - "enabled": true, "settable_per_mesh": false, "settable_per_extruder": false, "settable_per_meshgroup": false From 7dada6539c6571dfbb8d439e1df4d13db3543f05 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Sat, 26 Oct 2019 01:12:34 +0200 Subject: [PATCH 5/6] Fix minimum speeds and distances for wire printing Minimum distance is 0.001, i.e. one micrometre. Minimum speeds are set to Marlin's Minimum Planner Speed which is hardcoded. --- resources/definitions/fdmprinter.def.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index cd847ef8b6..f9c96693ea 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6700,7 +6700,7 @@ "unit": "mm", "default_value": 3, "value": "machine_nozzle_head_distance", - "minimum_value": "0.0001", + "minimum_value": "0.001", "maximum_value_warning": "20", "enabled": "wireframe_enabled", "settable_per_mesh": false, @@ -6730,7 +6730,7 @@ "unit": "mm/s", "type": "float", "default_value": 5, - "minimum_value": "0.1", + "minimum_value": "0.05", "maximum_value": "math.sqrt(machine_max_feedrate_x ** 2 + machine_max_feedrate_y ** 2 + machine_max_feedrate_z ** 2)", "maximum_value_warning": "50", "enabled": "wireframe_enabled", @@ -6746,7 +6746,7 @@ "unit": "mm/s", "type": "float", "default_value": 5, - "minimum_value": "0.1", + "minimum_value": "0.05", "maximum_value": "math.sqrt(machine_max_feedrate_x ** 2 + machine_max_feedrate_y ** 2)", "maximum_value_warning": "50", "enabled": "wireframe_enabled", @@ -6762,7 +6762,7 @@ "unit": "mm/s", "type": "float", "default_value": 5, - "minimum_value": "0.1", + "minimum_value": "0.05", "maximum_value": "math.sqrt(machine_max_feedrate_x ** 2 + machine_max_feedrate_y ** 2 + machine_max_feedrate_z ** 2)", "maximum_value_warning": "50", "enabled": "wireframe_enabled", @@ -6778,7 +6778,7 @@ "unit": "mm/s", "type": "float", "default_value": 5, - "minimum_value": "0.1", + "minimum_value": "0.05", "maximum_value": "math.sqrt(machine_max_feedrate_x ** 2 + machine_max_feedrate_y ** 2 + machine_max_feedrate_z ** 2)", "maximum_value_warning": "50", "enabled": "wireframe_enabled", @@ -6794,7 +6794,7 @@ "unit": "mm/s", "type": "float", "default_value": 5, - "minimum_value": "0.1", + "minimum_value": "0.05", "maximum_value": "math.sqrt(machine_max_feedrate_x ** 2 + machine_max_feedrate_y ** 2)", "maximum_value_warning": "100", "value": "wireframe_printspeed", @@ -7068,7 +7068,7 @@ "default_value": 0.01, "unit": "mm", "settable_per_mesh": false, - "minimum_value": "0.0001", + "minimum_value": "0.001", "settable_per_extruder": false, "settable_per_meshgroup": false }, From 0ea67d18d23109b35eeca99a598fe13b45213181 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Sun, 27 Oct 2019 01:00:17 +0200 Subject: [PATCH 6/6] Only show strategy-specific settings if their WP strategy is activated Reduces confusion, I hope, and the feeling of being overwhelmed by a load of settings, because obviously only people who make all settings visible are going to see these settings at all. --- resources/definitions/fdmprinter.def.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index f9c96693ea..8511d9e969 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6750,7 +6750,7 @@ "maximum_value": "math.sqrt(machine_max_feedrate_x ** 2 + machine_max_feedrate_y ** 2)", "maximum_value_warning": "50", "enabled": "wireframe_enabled", - "value": "wireframe_printspeed", + "value": "wireframe_printspeed_flat", "settable_per_mesh": false, "settable_per_extruder": false, "settable_per_meshgroup": false @@ -6917,7 +6917,7 @@ "default_value": 0.6, "minimum_value": "0", "maximum_value_warning": "2.0", - "enabled": "wireframe_enabled", + "enabled": "wireframe_enabled and wireframe_strategy == 'knot'", "settable_per_mesh": false, "settable_per_extruder": false, "settable_per_meshgroup": false @@ -6931,7 +6931,7 @@ "default_value": 0.5, "minimum_value": "0", "maximum_value_warning": "wireframe_height", - "enabled": "wireframe_enabled", + "enabled": "wireframe_enabled and wireframe_strategy == 'compensate'", "settable_per_mesh": false, "settable_per_extruder": false, "settable_per_meshgroup": false @@ -6945,7 +6945,7 @@ "default_value": 0.6, "minimum_value": "0", "maximum_value_warning": "wireframe_height", - "enabled": "wireframe_enabled", + "enabled": "wireframe_enabled and wireframe_strategy == 'compensate'", "settable_per_mesh": false, "settable_per_extruder": false, "settable_per_meshgroup": false