From b7296dd700e39bcaa92aab97ab6ff2c94d3f41c2 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Fri, 10 Jul 2020 13:48:47 +0200 Subject: [PATCH] Don't update material menu when it's not visible Knocks off about a second of loading --- resources/qml/Menus/SettingsMenu.qml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/resources/qml/Menus/SettingsMenu.qml b/resources/qml/Menus/SettingsMenu.qml index a7c8d7479f..939ade5847 100644 --- a/resources/qml/Menus/SettingsMenu.qml +++ b/resources/qml/Menus/SettingsMenu.qml @@ -2,7 +2,7 @@ //Cura is released under the terms of the LGPLv3 or higher. import QtQuick 2.2 -import QtQuick.Controls 1.1 +import QtQuick.Controls 1.4 import UM 1.2 as UM import Cura 1.0 as Cura @@ -24,7 +24,15 @@ Menu title: modelData.name property var extruder: (base.activeMachine === null) ? null : activeMachine.extruderList[model.index] NozzleMenu { title: Cura.MachineManager.activeDefinitionVariantsName; visible: Cura.MachineManager.activeMachine.hasVariants; extruderIndex: index } - MaterialMenu { title: catalog.i18nc("@title:menu", "&Material"); visible: Cura.MachineManager.activeMachine.hasMaterials; extruderIndex: index } + MaterialMenu + { + title: catalog.i18nc("@title:menu", "&Material") + visible: Cura.MachineManager.activeMachine.hasMaterials + extruderIndex: index + updateModels: false + onAboutToShow: updateModels = true + onAboutToHide: updateModels = false + } MenuSeparator {