3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-08 07:27:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Package upgrade should also check SDK version

Browse source
This commit is contained in:
Lipu Fei 2018-09-13 13:27:21 +02:00
parent 7a3e61e8f1
commit b39d6c7d87
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
plugins/Toolbox/src/Toolbox.py
View file

@ -488,7 +488,17 @@ class Toolbox(QObject, Extension):
local_version = Version(local_package["package_version"]) local_version = Version(local_package["package_version"])
remote_version = Version(remote_package["package_version"]) remote_version = Version(remote_package["package_version"])
return remote_version > local_version
can_upgrade = False
if remote_version > local_version:
can_upgrade = True
# A package with the same version can be built to have different SDK versions. So, for a package with the same
# version, we also need to check if the current one has a lower SDK version. If so, this package should also
# be upgradable.
elif remote_version == local_version and local_package.get("sdk_version", 0) < int(self._getSDKVersion()):
can_upgrade = True
return can_upgrade
@pyqtSlot(str, result = bool) @pyqtSlot(str, result = bool)
def canDowngrade(self, package_id: str) -> bool: def canDowngrade(self, package_id: str) -> bool: