From b137e6a36d9038cf80a2a4932d490c89dc7a366e Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Tue, 8 Oct 2019 15:21:19 +0200 Subject: [PATCH] Don't add extruders twice upon start-up The extruders are added when changing printers anyway, and we call this change signal upon start-up. So one of them is going to do unnecessary work. Contributes to issue CURA-6793. --- cura/Settings/ExtruderManager.py | 2 -- cura/Settings/MachineManager.py | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/cura/Settings/ExtruderManager.py b/cura/Settings/ExtruderManager.py index 417f7b01ff..121b465432 100755 --- a/cura/Settings/ExtruderManager.py +++ b/cura/Settings/ExtruderManager.py @@ -42,8 +42,6 @@ class ExtruderManager(QObject): # TODO; I have no idea why this is a union of ID's and extruder stacks. This needs to be fixed at some point. self._selected_object_extruders = [] # type: List[Union[str, "ExtruderStack"]] - self._addCurrentMachineExtruders() - Selection.selectionChanged.connect(self.resetSelectedObjectExtruders) ## Signal to notify other components when the list of extruders for a machine definition changes. diff --git a/cura/Settings/MachineManager.py b/cura/Settings/MachineManager.py index 13b2c76bc6..2454d5a67c 100755 --- a/cura/Settings/MachineManager.py +++ b/cura/Settings/MachineManager.py @@ -140,7 +140,7 @@ class MachineManager(QObject): activeVariantChanged = pyqtSignal() activeQualityChanged = pyqtSignal() activeIntentChanged = pyqtSignal() - activeStackChanged = pyqtSignal() # Emitted whenever the active stack is changed (ie: when changing between extruders, changing a profile, but not when changing a value) + activeStackChanged = pyqtSignal() # Emitted whenever the active extruder stack is changed (ie: when changing between extruders, changing a profile, but not when changing a value) extruderChanged = pyqtSignal() globalValueChanged = pyqtSignal() # Emitted whenever a value inside global container is changed.