Simplify some checks for connection types and group size

This commit is contained in:
ChrisTerBeke 2018-12-20 14:26:30 +01:00
parent 2f92f6ef50
commit af2061cd52
3 changed files with 31 additions and 18 deletions

View file

@ -11,10 +11,9 @@ Cura.ExpandablePopup
{
id: machineSelector
property var outputDevice: Cura.MachineManager.printerOutputDevices.length >= 1 ? Cura.MachineManager.printerOutputDevices[0] : null
property bool isPrinterConnected: Cura.MachineManager.printerConnected
property bool isNetworkPrinter: Cura.MachineManager.activeMachineHasActiveNetworkConnection
property bool isCloudPrinter: Cura.MachineManager.activeMachineHasActiveCloudConnection
property bool isGroup: Cura.MachineManager.activeMachineIsGroup
contentPadding: UM.Theme.getSize("default_lining").width
contentAlignment: Cura.ExpandablePopup.ContentAlignment.AlignLeft
@ -30,15 +29,13 @@ Cura.ExpandablePopup
text: isNetworkPrinter ? Cura.MachineManager.activeMachineNetworkGroupName : Cura.MachineManager.activeMachineName
source:
{
if (isNetworkPrinter)
{
if (machineSelector.outputDevice != null && machineSelector.outputDevice.clusterSize > 1)
{
return UM.Theme.getIcon("printer_group")
}
if (isGroup) {
return UM.Theme.getIcon("printer_group")
} else if (isNetworkPrinter || isCloudPrinter) {
return UM.Theme.getIcon("printer_single")
} else {
return ""
}
return ""
}
font: UM.Theme.getFont("medium")
iconColor: UM.Theme.getColor("machine_selector_printer_icon")
@ -53,12 +50,22 @@ Cura.ExpandablePopup
leftMargin: UM.Theme.getSize("thick_margin").width
}
source: machineSelector.isCloudPrinter ? UM.Theme.getIcon("printer_cloud_connected") : UM.Theme.getIcon("printer_connected")
source:
{
if (isNetworkPrinter) {
return UM.Theme.getIcon("printer_connected")
} else if (isCloudPrinter) {
return UM.Theme.getIcon("printer_cloud_connected")
} else {
return ""
}
}
width: UM.Theme.getSize("printer_status_icon").width
height: UM.Theme.getSize("printer_status_icon").height
color: UM.Theme.getColor("primary")
visible: isNetworkPrinter && isPrinterConnected
visible: isNetworkPrinter || isCloudPrinter
// Make a themable circle in the background so we can change it in other themes
Rectangle