3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 14:37:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Apply suggestions from code review

Browse source 
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
This commit is contained in:
Casper Lamboo 2022-03-11 09:59:20 +01:00 • committed by GitHub
parent 4f2e7116b7
commit addc5e36a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml
View file

@ -187,7 +187,7 @@ Item
// It kinda looks ugly otherwise (big panel, no content on it)
id: currentSettings
property int maximumHeight: 200 * screenScaleFactor
height: Math.min(contents.count * ((UM.Theme.getSize("section").height + UM.Theme.getSize("narrow_margin").height) + UM.Theme.getSize("default_lining").height), maximumHeight)
height: Math.min(contents.count * (UM.Theme.getSize("section").height + UM.Theme.getSize("narrow_margin").height + UM.Theme.getSize("default_lining").height), maximumHeight)
visible: currentMeshType != "anti_overhang_mesh"
ListView
@ -245,7 +245,7 @@ Item
{
id: settingLoader
width: UM.Theme.getSize("setting").width
height: UM.Theme.getSize("section").height + UM.Theme.getSize("narrow_margin").height
height: UM.Theme.getSize("section").height + UM.Theme.getSize("narrow_margin").height
enabled: provider.properties.enabled === "True"
property var definition: model
property var settingDefinitionsModel: addedSettingsModel

1
resources/qml/Settings/SettingItem.qml
View file

@ -18,7 +18,6 @@ Item
anchors.right: parent.right
// To avoid overlapping with the scrollBars
//anchors.rightMargin: UM.Theme.getSize("thin_margin").width
property alias contents: controlContainer.children
property alias hovered: mouse.containsMouse

2
resources/qml/Settings/SettingView.qml
View file

@ -217,7 +217,7 @@ Item
{
id: delegate
width: contents.width - (scrollBar.width +UM.Theme.getSize("narrow_margin").width)
width: contents.width - (scrollBar.width + UM.Theme.getSize("narrow_margin").width)
Behavior on height { NumberAnimation { duration: 100 } }
opacity: enabled ? 1 : 0
Behavior on opacity { NumberAnimation { duration: 100 } }