diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 1830a023c4..7941b13328 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -106,16 +106,8 @@ jobs: $HOME/.conan/conan_download_cache key: conan-${{ runner.os }}-${{ runner.arch }}-installer-cache - - name: Hack needed specifically for ubuntu-22.04 from mid-Feb 2023 onwards - if: ${{ startsWith(inputs.operating_system, 'ubuntu-22.04') }} - run: sudo apt remove libodbc2 libodbcinst2 unixodbc-common -y - - # NOTE: Due to what are probably github issues, we have to remove the cache and reconfigure before the rest. - # This is maybe because grub caches the disk it uses last time, which is recreated each time. - name: Install Linux system requirements run: | - sudo rm /var/cache/debconf/config.dat - sudo dpkg --configure -a sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y sudo apt update sudo apt upgrade @@ -157,6 +149,11 @@ jobs: - name: Create the Packages (Bash) run: conan install $CURA_CONAN_VERSION ${{ inputs.conan_args }} --build=missing --update -if cura_inst -g VirtualPythonEnv -o cura:enterprise=$ENTERPRISE -o cura:staging=$STAGING + - name: Remove internal packages before uploading + run: | + conan remove "*@internal/*" -f || true + conan remove "cura_private_data*" -f || true + - name: Upload the Package(s) if: always() run: | diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 4ae862b0fa..9f2d44bf80 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -158,8 +158,12 @@ jobs: - name: Create the Packages (Bash) run: conan install $CURA_CONAN_VERSION ${{ inputs.conan_args }} --build=missing --update -if cura_inst -g VirtualPythonEnv -o cura:enterprise=$ENTERPRISE -o cura:staging=$STAGING" + - name: Remove internal packages before uploading + run: | + conan remove "*@internal/*" -f || true + conan remove "cura_private_data*" -f || true + - name: Upload the Package(s) - if: ${{ inputs.operating_system != 'self-hosted' }} run: | conan upload "*" -r cura --all -c diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 067d811e9f..28790dd05a 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -124,6 +124,11 @@ jobs: - name: Create the Packages (Powershell) run: conan install $Env:CURA_CONAN_VERSION ${{ inputs.conan_args }} --build=missing --update -if cura_inst -g VirtualPythonEnv -o cura:enterprise=$Env:ENTERPRISE -o cura:staging=$Env:STAGING + - name: Remove internal packages before uploading + run: | + conan remove "*@internal/*" -f || true + conan remove "cura_private_data*" -f || true + - name: Upload the Package(s) if: always() run: | diff --git a/conanfile.py b/conanfile.py index 938ffd13fd..e046ba806d 100644 --- a/conanfile.py +++ b/conanfile.py @@ -218,7 +218,7 @@ class CuraConan(ConanFile): self.requires("cura_binary_data/(latest)@ultimaker/testing") self.requires("cpython/3.10.4") if self.options.internal: - self.requires("cura_private_data/(latest)@ultimaker/cura_10561") + self.requires("cura_private_data/(latest)@internal/cura_10561") self.requires("fdm_materials/(latest)@internal/testing") else: self.requires("fdm_materials/(latest)@ultimaker/testing") @@ -288,6 +288,12 @@ class CuraConan(ConanFile): copy(self, "*", cura_private_data.resdirs[0], str(self._share_dir.joinpath("cura"))) if self.options.devtools: + entitlements_file = "'{}'".format(os.path.join(self.source_folder, "packaging", "MacOS", "cura.entitlements")) + self._generate_pyinstaller_spec(location = self.generators_folder, + entrypoint_location = "'{}'".format(os.path.join(self.source_folder, self.conan_data["pyinstaller"]["runinfo"]["entrypoint"])).replace("\\", "\\\\"), + icon_path = "'{}'".format(os.path.join(self.source_folder, "packaging", self.conan_data["pyinstaller"]["icon"][str(self.settings.os)])).replace("\\", "\\\\"), + entitlements_file = entitlements_file if self.settings.os == "Macos" else "None") + # Update the po and pot files if self.settings.os != "Windows" or self.conf.get("tools.microsoft.bash:path", check_type=str): vb = VirtualBuildEnv(self) @@ -347,6 +353,12 @@ echo "CURA_APP_NAME={{ cura_app_name }}" >> ${{ env_prefix }}GITHUB_ENV self._generate_cura_version(os.path.join(self._site_packages, "cura")) + entitlements_file = "'{}'".format(Path(self.cpp_info.res_paths[2], "MacOS", "cura.entitlements")) + self._generate_pyinstaller_spec(location = self._base_dir, + entrypoint_location = "'{}'".format(os.path.join(self.package_folder, self.cpp_info.bindirs[0], self.conan_data["pyinstaller"]["runinfo"]["entrypoint"])).replace("\\", "\\\\"), + icon_path = "'{}'".format(os.path.join(self.package_folder, self.cpp_info.resdirs[2], self.conan_data["pyinstaller"]["icon"][str(self.settings.os)])).replace("\\", "\\\\"), + entitlements_file = entitlements_file if self.settings.os == "Macos" else "None") + def package(self): copy(self, "cura_app.py", src = self.source_folder, dst = os.path.join(self.package_folder, self.cpp.package.bindirs[0])) copy(self, "*", src = os.path.join(self.source_folder, "cura"), dst = os.path.join(self.package_folder, self.cpp.package.libdirs[0])) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index b6e6a027e9..3b7dc014f2 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -5130,7 +5130,7 @@ "support_z_distance": { "label": "Support Z Distance", - "description": "Distance from the top/bottom of the support structure to the print. This gap provides clearance to remove the supports after the model is printed. This value is rounded up to a multiple of the layer height.", + "description": "Distance from the top/bottom of the support structure to the print. This gap provides clearance to remove the supports after the model is printed. The topmost support layer below the model might be a fraction of regular layers.", "unit": "mm", "type": "float", "minimum_value": "0", @@ -5158,7 +5158,7 @@ "support_bottom_distance": { "label": "Support Bottom Distance", - "description": "Distance from the print to the bottom of the support.", + "description": "Distance from the print to the bottom of the support. Note that this is rounded up to the next layer height.", "unit": "mm", "minimum_value": "0", "maximum_value_warning": "machine_nozzle_size",