From a909c8f0298c95cf3e63a1e97389a6eef78fb876 Mon Sep 17 00:00:00 2001 From: Diego Prado Gesto Date: Tue, 11 Sep 2018 22:05:39 +0200 Subject: [PATCH] Don't emit signal if the favorite list didn't change. Contributes to CURA-5682. --- cura/Machines/MaterialManager.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/cura/Machines/MaterialManager.py b/cura/Machines/MaterialManager.py index 1463f2e40e..96572354b5 100644 --- a/cura/Machines/MaterialManager.py +++ b/cura/Machines/MaterialManager.py @@ -199,9 +199,14 @@ class MaterialManager(QObject): self.materialsUpdated.emit() favorites = self._application.getPreferences().getValue("cura/favorite_materials") + favorite_added = False for item in favorites.split(";"): - self._favorites.add(item) - self.favoritesUpdated.emit() + if item not in self._favorites: + self._favorites.add(item) + favorite_added = True + + if favorite_added: + self.favoritesUpdated.emit() def __addMaterialMetadataIntoLookupTree(self, material_metadata: dict) -> None: material_id = material_metadata["id"]