Fix minor codereview issues

CURA-333
This commit is contained in:
fieldOfView 2016-06-22 17:19:14 +02:00
parent 1e40d98fd7
commit a6bb0c804a
3 changed files with 5 additions and 4 deletions

View file

@ -82,6 +82,7 @@ class ExtrudersModel(UM.Qt.ListModel.ListModel):
def _onExtruderStackContainersChanged(self, container):
# The ExtrudersModel needs to be updated when the material-name or -color changes, because the user identifies extruders by material-name
if container.getMetaDataEntry("type") == "material":
self._updateExtruders()

View file

@ -73,7 +73,7 @@ class SolidView(View):
int(extruder_color[5:7], 16) / 255,
1.0
]
except:
except ValueError:
pass
if hasattr(node, "_outside_buildarea"):

View file

@ -336,10 +336,10 @@ Item
text: catalog.i18nc("@label", "Don't print support"),
color: ""
})
for(var extruderNr = 0; extruderNr < extruders.model.rowCount() ; extruderNr++) {
for(var extruderNumber = 0; extruderNumber < extruders.model.rowCount() ; extruderNumber++) {
extruderModel.append({
text: catalog.i18nc("@label", "Print using %1").arg(extruders.model.getItem(extruderNr).name),
color: extruders.model.getItem(extruderNr).colour
text: catalog.i18nc("@label", "Print using %1").arg(extruders.model.getItem(extruderNumber).name),
color: extruders.model.getItem(extruderNumber).colour
})
}
}