3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 06:57:28 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Fix minor codereview issues

Browse source 
CURA-333
This commit is contained in:
fieldOfView 2016-06-22 17:19:14 +02:00
parent 1e40d98fd7
commit a6bb0c804a
3 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
cura/ExtrudersModel.py
View file

@ -82,6 +82,7 @@ class ExtrudersModel(UM.Qt.ListModel.ListModel):
def _onExtruderStackContainersChanged(self, container): def _onExtruderStackContainersChanged(self, container):
# The ExtrudersModel needs to be updated when the material-name or -color changes, because the user identifies extruders by material-name
if container.getMetaDataEntry("type") == "material": if container.getMetaDataEntry("type") == "material":
self._updateExtruders() self._updateExtruders()

2
plugins/SolidView/SolidView.py
View file

@ -73,7 +73,7 @@ class SolidView(View):
int(extruder_color[5:7], 16) / 255, int(extruder_color[5:7], 16) / 255,
1.0 1.0
] ]
except: except ValueError:
pass pass
if hasattr(node, "_outside_buildarea"): if hasattr(node, "_outside_buildarea"):

6
resources/qml/SidebarSimple.qml
View file

@ -336,10 +336,10 @@ Item
text: catalog.i18nc("@label", "Don't print support"), text: catalog.i18nc("@label", "Don't print support"),
color: "" color: ""
}) })
for(var extruderNr = 0; extruderNr < extruders.model.rowCount() ; extruderNr++) { for(var extruderNumber = 0; extruderNumber < extruders.model.rowCount() ; extruderNumber++) {
extruderModel.append({ extruderModel.append({
text: catalog.i18nc("@label", "Print using %1").arg(extruders.model.getItem(extruderNr).name), text: catalog.i18nc("@label", "Print using %1").arg(extruders.model.getItem(extruderNumber).name),
color: extruders.model.getItem(extruderNr).colour color: extruders.model.getItem(extruderNumber).colour
}) })
} }
} }