From a46bf8d6fa7ec2602752c5a8e555b7d9f5c6cd23 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Thu, 8 Oct 2020 09:43:22 +0200 Subject: [PATCH] Apply suggestions from code review CURA-7440 Co-authored-by: Konstantinos Karmas --- cura/Arranging/ArrangeObjectsJob.py | 3 ++- cura/Arranging/Nest2DArrange.py | 2 +- cura/MultiplyObjectsJob.py | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cura/Arranging/ArrangeObjectsJob.py b/cura/Arranging/ArrangeObjectsJob.py index 82e979fd32..da6e936d8d 100644 --- a/cura/Arranging/ArrangeObjectsJob.py +++ b/cura/Arranging/ArrangeObjectsJob.py @@ -35,4 +35,5 @@ class ArrangeObjectsJob(Job): no_full_solution_message = Message(i18n_catalog.i18nc("@info:status", "Unable to find a location within the build volume for all objects"), title = i18n_catalog.i18nc("@info:title", "Can't Find Location")) no_full_solution_message.show() - self.finished.emit(self) \ No newline at end of file + self.finished.emit(self) + diff --git a/cura/Arranging/Nest2DArrange.py b/cura/Arranging/Nest2DArrange.py index 6774ebd982..36d391e8a2 100644 --- a/cura/Arranging/Nest2DArrange.py +++ b/cura/Arranging/Nest2DArrange.py @@ -23,7 +23,7 @@ def findNodePlacement(nodes_to_arrange: List["SceneNode"], build_volume: "BuildV :param build_volume: The build volume that we want to place the nodes in. It gets size & disallowed areas from this. :param fixed_nodes: List of nods that should not be moved, but should be used when deciding where the others nodes are placed. - :param factor: The library that we use is int based. This factor defines how accuracte we want it to be. + :param factor: The library that we use is int based. This factor defines how accurate we want it to be. :return: """ diff --git a/cura/MultiplyObjectsJob.py b/cura/MultiplyObjectsJob.py index e560411852..b54f7bcdce 100644 --- a/cura/MultiplyObjectsJob.py +++ b/cura/MultiplyObjectsJob.py @@ -74,7 +74,7 @@ class MultiplyObjectsJob(Job): nodes.append(new_node) factor = 10000 - found_solution_for_all, node_items = findNodePlacement(nodes, Application.getInstance().getBuildVolume(), fixed_nodes, factor = 10000) + found_solution_for_all, node_items = findNodePlacement(nodes, Application.getInstance().getBuildVolume(), fixed_nodes, factor = factor) not_fit_count = 0 if nodes: operation = GroupedOperation()