3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 23:17:32 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Simplify package compatibility checking

Browse source 
CURA-7207
This commit is contained in:
Nino van Hooff 2020-02-11 11:21:28 +01:00
parent ea44911a98
commit a33cfdfba6
1 changed files with 2 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
plugins/Toolbox/src/CloudSync/SubscribedPackagesModel.py
View file

@ -63,7 +63,8 @@ class SubscribedPackagesModel(ListModel):
"is_dismissed": False,
}
package.update({"is_compatible": self._isAnyVersionCompatible(package_manager, item["sdk_versions"])})
compatible = any(package_manager.isPackageCompatible(Version(version)) for version in item["sdk_versions"])
package.update({"is_compatible": compatible})
try:
package.update({"icon_url": item["icon_url"]})
@ -71,12 +72,3 @@ class SubscribedPackagesModel(ListModel):
package.update({"icon_url": ""})
self._items.append(package)
self.setItems(self._items)
@staticmethod
def _isAnyVersionCompatible(package_manager: PackageManager, api_versions: List[str]) -> bool:
"""
Check a list of version numbers if any of them applies to our
application.
:return: ``True`` when any of the provided API versions is compatible.
"""
return any(package_manager.isPackageCompatible(Version(version)) for version in api_versions)