3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 23:17:32 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Simplify code in MachineManager

Browse source
This commit is contained in:
Lipu Fei 2018-03-03 16:01:59 +01:00
parent 413e4ca55d
commit a220b55856
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
cura/Settings/MachineManager.py
View file

@ -118,6 +118,7 @@ class MachineManager(QObject):
containers[0].nameChanged.connect(self._onMaterialNameChanged) containers[0].nameChanged.connect(self._onMaterialNameChanged)
self._material_manager = self._application._material_manager self._material_manager = self._application._material_manager
self._quality_manager = self._application.getQualityManager()
# When the materials lookup table gets updated, it can mean that a material has its name changed, which should # When the materials lookup table gets updated, it can mean that a material has its name changed, which should
# be reflected on the GUI. This signal emission makes sure that it happens. # be reflected on the GUI. This signal emission makes sure that it happens.
@ -853,11 +854,8 @@ class MachineManager(QObject):
self.activeQualityChangesGroupChanged.emit() self.activeQualityChangesGroupChanged.emit()
def _setQualityChangesGroup(self, quality_changes_group): def _setQualityChangesGroup(self, quality_changes_group):
# TODO: quality_changes groups depend on a quality_type. Here it's fetching the quality_types every time.
# Can we do this better, like caching the quality group a quality_changes group depends on?
quality_type = quality_changes_group.quality_type quality_type = quality_changes_group.quality_type
quality_manager = Application.getInstance()._quality_manager quality_group_dict = self._quality_manager.getQualityGroups(self._global_container_stack)
quality_group_dict = quality_manager.getQualityGroups(self._global_container_stack)
quality_group = quality_group_dict[quality_type] quality_group = quality_group_dict[quality_type]
quality_changes_container = self._empty_quality_changes_container quality_changes_container = self._empty_quality_changes_container