3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 23:17:32 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Apply division by zero prevention to the denominator

Browse source 
Rather than the numerator, which could not cause a division by zero exception.
This commit is contained in:
Ghostkeeper 2019-01-28 16:40:45 +01:00
parent 3dcb6b9c37
commit 9d8cf5ddde
No known key found for this signature in database
GPG key ID: 86BEF881AE2CF276
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
cura/PrinterOutput/PrintJobOutputModel.py
View file

@ -132,8 +132,7 @@ class PrintJobOutputModel(QObject):
@pyqtProperty(float, notify = timeElapsedChanged) @pyqtProperty(float, notify = timeElapsedChanged)
def progress(self) -> float: def progress(self) -> float:
time_elapsed = max(float(self.timeElapsed), 1.0) # Prevent a division by zero exception result = float(self.timeElapsed) / max(self.timeTotal, 1.0) # Prevent a division by zero exception.
result = time_elapsed / self.timeTotal
return min(result, 1.0) # Never get a progress past 1.0 return min(result, 1.0) # Never get a progress past 1.0
@pyqtProperty(str, notify=stateChanged) @pyqtProperty(str, notify=stateChanged)