3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Assert that there is no ID metadata entry in definition containers

Browse source
This commit is contained in:
Ghostkeeper 2019-10-22 11:01:16 +02:00
parent d561810024
commit 985aac9e60
No known key found for this signature in database
GPG key ID: 59A4C0959592C05C
1 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
tests/Settings/TestDefinitionContainer.py
View file

@ -58,7 +58,7 @@ def assertIsDefinitionValid(definition_container, path, file_name):
# definition that defines a "value", the "default_value" is ineffective. This
# test fails on those things.
@pytest.mark.parametrize("file_name", machine_filepaths)
def test_validateOverridingDefaultValue(file_name):
def test_validateOverridingDefaultValue(file_name: str):
definition_path = os.path.join(os.path.dirname(__file__), "..", "..", "resources", "definitions", file_name)
with open(definition_path, encoding = "utf-8") as f:
doc = json.load(f)
@ -125,3 +125,15 @@ def merge_dicts(base: Dict[str, Any], overrides: Dict[str, Any]) -> Dict[str, An
else:
result[key] = val
return result
## Verifies that definition contains don't have an ID field.
#
# ID fields are legacy. They should not be used any more. This is legacy that
# people don't seem to be able to get used to.
@pytest.mark.parametrize("file_name", machine_filepaths)
def test_noId(file_name):
definition_path = os.path.join(os.path.dirname(__file__), "..", "..", "resources", "definitions", file_name)
with open(definition_path, encoding = "utf-8") as f:
doc = json.load(f)
assert "id" not in doc, "Definitions should not have an ID field."