From 9821793b46428b299e2b1daacf7cf4e553350148 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Fri, 15 Jun 2018 15:16:55 +0200 Subject: [PATCH] Don't override boundingbox of SceneNode Whatever was intended here, it didn't work. Because when a method is called it is called on the class of the object. Methods are not attributes of instances but attributes of the class. The attribute of the class was never changed, so this had no effect. Contributes to issue CURA-5330. --- plugins/GCodeReader/FlavorParser.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/plugins/GCodeReader/FlavorParser.py b/plugins/GCodeReader/FlavorParser.py index 5da1a79fb7..de6469516e 100644 --- a/plugins/GCodeReader/FlavorParser.py +++ b/plugins/GCodeReader/FlavorParser.py @@ -92,10 +92,6 @@ class FlavorParser: if message == self._message: self._cancelled = True - @staticmethod - def _getNullBoundingBox() -> AxisAlignedBox: - return AxisAlignedBox(minimum=Vector(0, 0, 0), maximum=Vector(10, 10, 10)) - def _createPolygon(self, layer_thickness: float, path: List[List[Union[float, int]]], extruder_offsets: List[float]) -> bool: countvalid = 0 for point in path: @@ -294,9 +290,6 @@ class FlavorParser: self._filament_diameter = global_stack.extruders[str(self._extruder_number)].getProperty("material_diameter", "value") scene_node = CuraSceneNode() - # Override getBoundingBox function of the sceneNode, as this node should return a bounding box, but there is no - # real data to calculate it from. - scene_node.getBoundingBox = self._getNullBoundingBox gcode_list = [] self._is_layers_in_file = False