3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-25 15:44:04 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Update extruderCount when extrudersModel got changed

Browse source 
CURA-3755

The Timer delay is not reliable for updating the extruder Tabs.
So we now rely on the modelChanged signal of the ExtrudersModel
to do the update.
This commit is contained in:
Lipu Fei 2017-05-11 09:42:56 +02:00
parent 04611b06af
commit 9060bbf3b2
1 changed files with 5 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

22
plugins/MachineSettingsAction/MachineSettingsAction.qml
View file

@ -16,23 +16,13 @@ Cura.MachineAction
property var extrudersModel: Cura.ExtrudersModel{} property var extrudersModel: Cura.ExtrudersModel{}
property int extruderTabsCount: 0 property int extruderTabsCount: 0
Component.onCompleted: Connections
{ {
// Populate extruder tabs after a short delay, because otherwise the tabs that are added when target: base.extrudersModel
// the dialog is created are stuck. onModelChanged:
extruderTabsCountDelay.start();
}
Timer
{
id: extruderTabsCountDelay
repeat: false
interval: 1
onTriggered:
{ {
var extruderCount = parseInt(machineExtruderCountProvider.properties.value); var extruderCount = base.extrudersModel.rowCount();
base.extruderTabsCount = (extruderCount > 1) ? extruderCount : 0; base.extruderTabsCount = extruderCount > 1 ? extruderCount : 0;
} }
} }
@ -46,7 +36,6 @@ Cura.MachineAction
onAccepted: manager.onFinishAction() onAccepted: manager.onFinishAction()
onRejected: manager.onFinishAction() onRejected: manager.onFinishAction()
onClosing: manager.onFinishAction() onClosing: manager.onFinishAction()
onVisibilityChanged: extruderTabsCountDelay.start()
} }
anchors.fill: parent; anchors.fill: parent;
@ -383,7 +372,6 @@ Cura.MachineAction
onActivated: onActivated:
{ {
manager.setMachineExtruderCount(index + 1); manager.setMachineExtruderCount(index + 1);
base.extruderTabsCount = (index > 0) ? index + 1 : 0;
} }
} }