From 8ea8cc752fe3addb9e0eb8a13ec205e8d3a51c0a Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Mon, 22 Nov 2021 14:44:52 +0100 Subject: [PATCH] Also call processing functions for error callbacks Otherwise the appropriate callbacks might not get called. Contributes to issue CURA-8539. --- cura/OAuth2/AuthorizationHelpers.py | 3 ++- cura/OAuth2/AuthorizationService.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cura/OAuth2/AuthorizationHelpers.py b/cura/OAuth2/AuthorizationHelpers.py index 28b07cf17c..ac16ea9c9f 100644 --- a/cura/OAuth2/AuthorizationHelpers.py +++ b/cura/OAuth2/AuthorizationHelpers.py @@ -73,7 +73,8 @@ class AuthorizationHelpers: self._token_url, data = urllib.parse.urlencode(data).encode("UTF-8"), headers_dict = headers, - callback = lambda response: self.parseTokenResponse(response, callback) + callback = lambda response: self.parseTokenResponse(response, callback), + error_callback = lambda response: self.parseTokenResponse(response, callback) ) def parseTokenResponse(self, token_response: QNetworkReply, callback: Callable[[AuthenticationResponse], None]) -> None: diff --git a/cura/OAuth2/AuthorizationService.py b/cura/OAuth2/AuthorizationService.py index 290fc5c651..98c09c6873 100644 --- a/cura/OAuth2/AuthorizationService.py +++ b/cura/OAuth2/AuthorizationService.py @@ -134,7 +134,7 @@ class AuthorizationService: self._auth_helpers.getAccessTokenUsingRefreshToken(self._auth_data.refresh_token, process_auth_data) - self._auth_helpers.checkToken(self._auth_data.access_token, check_user_profile, lambda: callback(None)) + self._auth_helpers.checkToken(self._auth_data.access_token, check_user_profile, lambda: check_user_profile(None)) def getAccessToken(self) -> Optional[str]: """Get the access token as provided by the response data."""