3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

FirmwareUpdateChecker: Remove superfluous 'version_parser' as a setting, since it broke lean principles.

Browse source
This commit is contained in:
Remco Burema 2018-10-13 19:36:11 +02:00
parent 60408c14bc
commit 8c71a8855c
3 changed files with 9 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

9
plugins/FirmwareUpdateChecker/FirmwareUpdateCheckerJob.py
View file

@ -46,14 +46,17 @@ class FirmwareUpdateCheckerJob(Job):
return result
def parseVersionResponse(self, response: str) -> Version:
raw_str = response.split("\n", 1)[0].rstrip()
return Version(raw_str)
def getCurrentVersionForMachine(self, machine_id: int) -> Version:
max_version = self.ZERO_VERSION
machine_urls = self._lookups.getCheckUrlsFor(machine_id)
parse_function = self._lookups.getParseVersionUrlFor(machine_id)
if machine_urls is not None and parse_function is not None:
if machine_urls is not None:
for url in machine_urls:
version = parse_function(self.getUrlResponse(url))
version = self.parseVersionResponse(self.getUrlResponse(url))
if version > max_version:
max_version = version