3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 06:57:28 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Fix crash when port gets disconnected while iterating

Browse source 
Fixes Sentry issue CURA-11T.
This commit is contained in:
Ghostkeeper 2020-07-20 12:10:08 +02:00
parent 528c8e2226
commit 8c4533a2c3
No known key found for this signature in database
GPG key ID: D2A8871EE34EC59A
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugins/USBPrinting/USBPrinterOutputDeviceManager.py
View file

@ -1,4 +1,4 @@
# Copyright (c) 2018 Ultimaker B.V. # Copyright (c) 2020 Ultimaker B.V.
# Cura is released under the terms of the LGPLv3 or higher. # Cura is released under the terms of the LGPLv3 or higher.
import threading import threading
@ -117,6 +117,8 @@ class USBPrinterOutputDeviceManager(QObject, OutputDevicePlugin):
for port in serial.tools.list_ports.comports(): for port in serial.tools.list_ports.comports():
if not isinstance(port, tuple): if not isinstance(port, tuple):
port = (port.device, port.description, port.hwid) port = (port.device, port.description, port.hwid)
if not port[2]: # HWID may be None if the port got disconnected while processing.
continue
if only_list_usb and not port[2].startswith("USB"): if only_list_usb and not port[2].startswith("USB"):
continue continue