From 8a5026bdb185e4f3b1aa6eabf1142d6c38293ed3 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Wed, 5 Oct 2016 13:28:53 +0200 Subject: [PATCH] Revert "Early cop-out if there is no printer connected" This reverts commit 99f53cb8322e07f1ff94195e44ecbcde0b82e841. That commit caused the progress bar to be indeterminate if the progress bar was not visible, which is semantically correct but in reality causes QML to redraw the screen constantly for the animation of the indeterminate progress bar. This was taking up CPU. Now the CPU is only taken up during the pausing and resuming states when the progress bar is visible and indeterminate, but then it is actually required. Contributes to issue CURA-2497. --- resources/qml/MonitorButton.qml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/resources/qml/MonitorButton.qml b/resources/qml/MonitorButton.qml index 83d8b4bfc9..607d0a24ca 100644 --- a/resources/qml/MonitorButton.qml +++ b/resources/qml/MonitorButton.qml @@ -161,10 +161,6 @@ Rectangle visible: showProgress; indeterminate: { - if (!printerConnected) - { - return true; - } switch(Cura.MachineManager.printerOutputDevices[0].jobState) { case "pausing":