3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 23:17:32 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Catch FileNotFoundError when updating custom firmware

Browse source 
In case there is a bug there, we won't crash the thread.
This commit is contained in:
Ghostkeeper 2018-03-14 14:23:40 +01:00
parent 0655ef0bc5
commit 877d061a1b
No known key found for this signature in database
GPG key ID: 5252B696FB5E7C7A
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugins/USBPrinting/USBPrinterOutputDevice.py
View file

@ -127,9 +127,11 @@ class USBPrinterOutputDevice(PrinterOutputDevice):
if self._connection_state != ConnectionState.closed: if self._connection_state != ConnectionState.closed:
self.close() self.close()
hex_file = intelHex.readHex(self._firmware_location) try:
if len(hex_file) == 0: hex_file = intelHex.readHex(self._firmware_location)
Logger.log("e", "Unable to read provided hex file. Could not update firmware") assert len(hex_file) > 0
except (FileNotFoundError, AssertionError):
Logger.log("e", "Unable to read provided hex file. Could not update firmware.")
self.setFirmwareUpdateState(FirmwareUpdateState.firmware_not_found_error) self.setFirmwareUpdateState(FirmwareUpdateState.firmware_not_found_error)
return return