3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-25 15:44:04 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Fix minor review comments

Browse source 
CURA-6598
This commit is contained in:
Jaime van Kessel 2019-09-18 14:17:26 +02:00
parent fade8d3644
commit 84e5114566
No known key found for this signature in database
GPG key ID: 3710727397403C91
2 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
resources/qml/PrintSetupSelector/Custom/QualitiesWithIntentMenu.qml
View file

@ -182,11 +182,12 @@ Popup
Rectangle Rectangle
{ {
height: 1 height: UM.Theme.getSize("default_lining").height
anchors.left: parent.left anchors.left: parent.left
anchors.right: parent.right anchors.right: parent.right
color: borderColor color: borderColor
} }
MenuButton MenuButton
{ {
labelText: Cura.Actions.addProfile.text labelText: Cura.Actions.addProfile.text

14
resources/qml/RadioCheckbar.qml
View file

@ -14,7 +14,7 @@ Item
property color activeColor: UM.Theme.getColor("primary") property color activeColor: UM.Theme.getColor("primary")
property color inactiveColor: UM.Theme.getColor("slider_groove") property color inactiveColor: UM.Theme.getColor("slider_groove")
property color defaultItemColor: UM.Theme.getColor("small_button_active") property color defaultItemColor: UM.Theme.getColor("small_button_active")
property int checkboxSize: UM.Theme.getSize("radio_button").height * 0.75 property int checkboxSize: Math.round(UM.Theme.getSize("radio_button").height * 0.75)
property int inactiveMarkerSize: 2 * barSize property int inactiveMarkerSize: 2 * barSize
property int barSize: UM.Theme.getSize("slider_groove_radius").height property int barSize: UM.Theme.getSize("slider_groove_radius").height
property var isCheckedFunction // Function that accepts the modelItem and returns if the item should be active. property var isCheckedFunction // Function that accepts the modelItem and returns if the item should be active.
@ -36,8 +36,8 @@ Item
{ {
left: buttonBar.left left: buttonBar.left
right: buttonBar.right right: buttonBar.right
leftMargin: (checkboxSize - inactiveMarkerSize) / 2 leftMargin: Math.round((checkboxSize - inactiveMarkerSize) / 2)
rightMargin: (checkboxSize - inactiveMarkerSize) / 2 rightMargin: Math.round((checkboxSize - inactiveMarkerSize) / 2)
verticalCenter: parent.verticalCenter verticalCenter: parent.verticalCenter
} }
} }
@ -72,7 +72,7 @@ Item
property Item previousItem: repeater.itemAt(index - 1) property Item previousItem: repeater.itemAt(index - 1)
height: barSize height: barSize
width: buttonBar.width / (repeater.count - 1) - activeComponent.width - 2 width: Math.round(buttonBar.width / (repeater.count - 1) - activeComponent.width - 2)
color: defaultItemColor color: defaultItemColor
anchors anchors
@ -110,7 +110,7 @@ Item
anchors.horizontalCenter: parent.horizontalCenter anchors.horizontalCenter: parent.horizontalCenter
height: inactiveMarkerSize height: inactiveMarkerSize
width: inactiveMarkerSize width: inactiveMarkerSize
radius: width / 2 radius: Math.round(width / 2)
color: inactiveColor color: inactiveColor
} }
} }
@ -132,7 +132,7 @@ Item
{ {
height: checkboxSize height: checkboxSize
width: checkboxSize width: checkboxSize
radius: width / 2 radius: Math.round(width / 2)
border.color: defaultItemColor border.color: defaultItemColor
@ -143,7 +143,7 @@ Item
margins: 3 margins: 3
fill: parent fill: parent
} }
radius: width / 2 radius: Math.round(width / 2)
color: activeColor color: activeColor
visible: checkbox.checked visible: checkbox.checked
} }