3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-11-02 20:52:20 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Apply suggestions from code review

Browse source 
Change some margins for the corresponding absolute values instead of adding formulas.

Contributes to CURA-5876.

Co-Authored-By: diegopradogesto <d.pradogesto@ultimaker.com>
This commit is contained in:
Jaime van Kessel 2018-12-13 14:36:58 +01:00 • committed by GitHub
parent f38f140430
commit 8091b2810c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

16
resources/qml/Menus/ConfigurationMenu/ConfigurationItem.qml
View file

@ -36,9 +36,9 @@ Button
anchors anchors
{ {
left: parent.left left: parent.left
leftMargin: 2 * parent.padding leftMargin: UM.Theme.getSize("wide_margin").width
right: parent.right right: parent.right
rightMargin: 2 * parent.padding rightMargin: UM.Theme.getSize("wide_margin").width
} }
spacing: UM.Theme.getSize("default_margin").width spacing: UM.Theme.getSize("default_margin").width
@ -64,9 +64,9 @@ Button
anchors anchors
{ {
left: parent.left left: parent.left
leftMargin: 2 * parent.padding leftMargin: UM.Theme.getSize("wide_margin").width
right: parent.right right: parent.right
rightMargin: 2 * parent.padding rightMargin: UM.Theme.getSize("wide_margin").width
} }
height: visible ? Math.round(UM.Theme.getSize("default_lining").height / 2) : 0 height: visible ? Math.round(UM.Theme.getSize("default_lining").height / 2) : 0
color: UM.Theme.getColor("lining") color: UM.Theme.getColor("lining")
@ -79,9 +79,9 @@ Button
anchors anchors
{ {
left: parent.left left: parent.left
leftMargin: 2 * parent.padding leftMargin: UM.Theme.getSize("wide_margin").width
right: parent.right right: parent.right
rightMargin: 2 * parent.padding rightMargin: UM.Theme.getSize("wide_margin").width
} }
height: childrenRect.height height: childrenRect.height
visible: configuration.buildplateConfiguration != "" visible: configuration.buildplateConfiguration != ""
@ -101,7 +101,7 @@ Button
id: buildplateLabel id: buildplateLabel
anchors.left: buildplateIcon.right anchors.left: buildplateIcon.right
anchors.verticalCenter: buildplateIcon.verticalCenter anchors.verticalCenter: buildplateIcon.verticalCenter
anchors.leftMargin: Math.round(UM.Theme.getSize("default_margin").height / 2) anchors.leftMargin: UM.Theme.getSize("narrow_margin").height
text: configuration.buildplateConfiguration text: configuration.buildplateConfiguration
renderType: Text.NativeRendering renderType: Text.NativeRendering
color: UM.Theme.getColor("text") color: UM.Theme.getColor("text")
@ -127,4 +127,4 @@ Button
{ {
Cura.MachineManager.applyRemoteConfiguration(configuration) Cura.MachineManager.applyRemoteConfiguration(configuration)
} }
} }

4
resources/qml/Menus/ConfigurationMenu/ConfigurationListView.qml
View file

@ -28,7 +28,7 @@ Item
{ {
width: parent.width width: parent.width
visible: configurationList.model.length == 0 visible: configurationList.model.length == 0
height: label.height + 2 * UM.Theme.getSize("default_margin").height height: label.height + UM.Theme.getSize("wide_margin").height
anchors.top: parent.top anchors.top: parent.top
anchors.topMargin: UM.Theme.getSize("default_margin").height anchors.topMargin: UM.Theme.getSize("default_margin").height
@ -134,4 +134,4 @@ Item
forceModelUpdate() forceModelUpdate()
} }
} }
} }