3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-11-02 20:52:20 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove redundant setProperties

Browse source 
CURA-4916
This commit is contained in:
Lipu Fei 2018-02-28 12:45:58 +01:00
parent e533c4604c
commit 7f5bb70bee
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
resources/qml/SidebarSimple.qml
View file

@ -522,9 +522,6 @@ Item
// Update the slider value to represent the rounded value // Update the slider value to represent the rounded value
infillSlider.value = roundedSliderValue infillSlider.value = roundedSliderValue
// Explicitly cast to string to make sure the value passed to Python is an integer.
infillDensity.setPropertyValue("value", String(roundedSliderValue))
Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", roundedSliderValue) Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", roundedSliderValue)
} }
@ -655,21 +652,19 @@ Item
onClicked: { onClicked: {
// Set to 90% only when enabling gradual infill // Set to 90% only when enabling gradual infill
var newInfillDensity;
if (parseInt(infillSteps.properties.value) == 0) { if (parseInt(infillSteps.properties.value) == 0) {
previousInfillDensity = parseInt(infillDensity.properties.value) previousInfillDensity = parseInt(infillDensity.properties.value)
infillDensity.setPropertyValue("value", String(90)) newInfillDensity = 90;
Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", String(90))
} else { } else {
infillDensity.setPropertyValue("value", String(previousInfillDensity)) newInfillDensity = previousInfillDensity;
Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", String(previousInfillDensity))
} }
Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", String(newInfillDensity))
var infill_steps_value = 0; var infill_steps_value = 0;
if (parseInt(infillSteps.properties.value) == 0) if (parseInt(infillSteps.properties.value) == 0)
infill_steps_value = 5; infill_steps_value = 5;
infillSteps.setPropertyValue("value", infill_steps_value)
Cura.MachineManager.setSettingForAllExtruders("gradual_infill_steps", "value", infill_steps_value) Cura.MachineManager.setSettingForAllExtruders("gradual_infill_steps", "value", infill_steps_value)
} }