3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Automatic abortRequest for each API request

Browse source 
Defensive programming

Contributes to: CURA-8587
This commit is contained in:
Jelle Spijker 2021-12-08 10:18:08 +01:00
parent 453de95d12
commit 7be2da587b
No known key found for this signature in database
GPG key ID: 6662DC033BE6B99A
3 changed files with 17 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

12
plugins/Marketplace/RemotePackageList.py
View file

@ -33,13 +33,6 @@ class RemotePackageList(PackageList):
self.isLoadingChanged.connect(self._onLoadingChanged)
self.isLoadingChanged.emit()
def __del__(self) -> None:
"""
When deleting this object, abort the request so that we don't get a callback from it later on a deleted C++
object.
"""
self.abortUpdating()
@pyqtSlot()
def updatePackages(self) -> None:
"""
@ -57,11 +50,6 @@ class RemotePackageList(PackageList):
error_callback = self._onError
)
@pyqtSlot()
def abortUpdating(self) -> None:
HttpRequestManager.getInstance().abortRequest(self._ongoing_requests["get_packages"])
self._ongoing_requests["get_packages"] = None
def reset(self) -> None:
self.clear()
self._request_url = self._initialRequestUrl()