3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-08-08 22:35:03 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix QML warnings due to depricated on<signal> calls in Connections

Browse source 
As of 5.12, the signals used in connections should not be declared as on<signal>, but as
function on<signal>(arguments).
This commit is contained in:
Kostas Karmas 2021-03-30 08:46:14 +02:00
parent a277adae64
commit 7827b36ab7
46 changed files with 113 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

2
plugins/MachineSettingsAction/MachineSettingsAction.qml
View file

@ -27,7 +27,7 @@ Cura.MachineAction
Connections
{
target: extrudersModel
onItemsChanged: tabNameModel.update()
function onItemsChanged() { tabNameModel.update() }
}
ListModel

2
plugins/MachineSettingsAction/MachineSettingsPrinterTab.qml
View file

@ -326,7 +326,7 @@ Item
Connections
{
target: Cura.MachineManager
onGlobalContainerChanged: extruderCountModel.update()
function onGlobalContainerChanged() { extruderCountModel.update() }
}
}

2
plugins/PerObjectSettingsTool/PerObjectItem.qml
View file

@ -35,7 +35,7 @@ UM.TooltipArea
Connections
{
target: addedSettingsModel
onVisibleCountChanged:
function onVisibleCountChanged()
{
check.checked = addedSettingsModel.getVisible(model.key)
}

4
plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml
View file

@ -334,13 +334,13 @@ Item
Connections
{
target: inheritStackProvider
onPropertiesChanged: provider.forcePropertiesChanged()
function onPropertiesChanged() { provider.forcePropertiesChanged() }
}
Connections
{
target: UM.ActiveTool
onPropertiesChanged:
function onPropertiesChanged()
{
// the values cannot be bound with UM.ActiveTool.properties.getValue() calls,
// so here we connect to the signal and update the those values.

2
plugins/PostProcessingPlugin/PostProcessingPlugin.qml
View file

@ -414,7 +414,7 @@ UM.Dialog
{
target: item
onShowTooltip:
function onShowTooltip(text)
{
tooltip.text = text
var position = settingLoader.mapToItem(settingsPanel, settingsPanel.x, 0)

12
plugins/SimulationView/SimulationViewMainComponent.qml
View file

@ -55,8 +55,8 @@ Item
Connections
{
target: UM.SimulationView
onMaxPathsChanged: pathSlider.setHandleValue(UM.SimulationView.currentPath)
onCurrentPathChanged:
function onMaxPathsChanged() { pathSlider.setHandleValue(UM.SimulationView.currentPath) }
function onCurrentPathChanged()
{
// Only pause the simulation when the layer was changed manually, not when the simulation is running
if (pathSlider.manuallyChanged)
@ -89,7 +89,7 @@ Item
Connections
{
target: UM.Preferences
onPreferenceChanged:
function onPreferenceChanged(preference)
{
if (preference !== "view/only_show_top_layers" && preference !== "view/top_layer_count" && ! preference.match("layerview/"))
{
@ -221,9 +221,9 @@ Item
Connections
{
target: UM.SimulationView
onMaxLayersChanged: layerSlider.setUpperValue(UM.SimulationView.currentLayer)
onMinimumLayerChanged: layerSlider.setLowerValue(UM.SimulationView.minimumLayer)
onCurrentLayerChanged:
function onMaxLayersChanged() { layerSlider.setUpperValue(UM.SimulationView.currentLayer) }
function onMinimumLayerChanged() { layerSlider.setLowerValue(UM.SimulationView.minimumLayer) }
function onCurrentLayerChanged()
{
// Only pause the simulation when the layer was changed manually, not when the simulation is running
if (layerSlider.manuallyChanged)

2
plugins/SimulationView/SimulationViewMenuComponent.qml
View file

@ -22,7 +22,7 @@ Cura.ExpandableComponent
Connections
{
target: UM.Preferences
onPreferenceChanged:
function onPreferenceChanged(preference)
{
if (preference !== "view/only_show_top_layers" && preference !== "view/top_layer_count" && ! preference.match("layerview/"))
{

4
plugins/Toolbox/resources/qml/Toolbox.qml
View file

@ -100,8 +100,8 @@ Window
Connections
{
target: toolbox
onShowLicenseDialog: { licenseDialog.show() }
onCloseLicenseDialog: { licenseDialog.close() }
function onShowLicenseDialog() { licenseDialog.show() }
function onCloseLicenseDialog() { licenseDialog.close() }
}
ToolboxLicenseDialog

4
plugins/Toolbox/resources/qml/components/ToolboxDetailTileActions.qml
View file

@ -112,8 +112,8 @@ Column
Connections
{
target: toolbox
onInstallChanged: installed = toolbox.isInstalled(model.id)
onFilterChanged:
function onInstallChanged() { installed = toolbox.isInstalled(model.id) }
function onFilterChanged()
{
installed = toolbox.isInstalled(model.id)
}

2
plugins/Toolbox/resources/qml/components/ToolboxInstalledTile.qml
View file

@ -117,7 +117,7 @@ Item
Connections
{
target: toolbox
onEnabledChanged: isEnabled = toolbox.isEnabled(model.id)
function onEnabledChanged() { isEnabled = toolbox.isEnabled(model.id) }
}
}
}

2
plugins/Toolbox/resources/qml/components/ToolboxInstalledTileActions.qml
View file

@ -81,7 +81,7 @@ Column
Connections
{
target: toolbox
onMetadataChanged:
function onMetadataChanged()
{
canDowngrade = toolbox.canDowngrade(model.id)
}