3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 14:37:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Don't unnecessarily cast to a set

Browse source 
The InstanceContainer version of getAllKeys was first casting to a list but I removed that, because everywhere where we were using it we were casting it directly to a set.

Contributes to issue CURA-5330.
This commit is contained in:
Ghostkeeper 2018-06-15 13:07:55 +02:00
parent b9727a33c6
commit 75e5a185d9
No known key found for this signature in database
GPG key ID: 5252B696FB5E7C7A
4 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugins/GCodeWriter/GCodeWriter.py
View file

@ -140,7 +140,7 @@ class GCodeWriter(MeshWriter):
serialized = flat_global_container.serialize()
data = {"global_quality": serialized}
all_setting_keys = set(flat_global_container.getAllKeys())
all_setting_keys = flat_global_container.getAllKeys()
for extruder in sorted(stack.extruders.values(), key = lambda k: int(k.getMetaDataEntry("position"))):
extruder_quality = extruder.qualityChanges
if extruder_quality.getId() == "empty_quality_changes":
@ -167,7 +167,7 @@ class GCodeWriter(MeshWriter):
extruder_serialized = flat_extruder_quality.serialize()
data.setdefault("extruder_quality", []).append(extruder_serialized)
all_setting_keys.update(set(flat_extruder_quality.getAllKeys()))
all_setting_keys.update(flat_extruder_quality.getAllKeys())
# Check if there is any profiles
if not all_setting_keys: