3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 23:17:32 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Revert: Refactor UploadBackupJob to use HttpRequestManager

Browse source 
It doesn't make sense to have a Job using HttpRequestManager
because both are async and

Note that the job itself should not emit finished, the JobQueue does that.
This commit is contained in:
Nino van Hooff 2020-03-02 15:12:42 +01:00
parent 6c9b9909ba
commit 7243dc63a4
2 changed files with 14 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugins/CuraDrive/src/DriveApiService.py
View file

@ -87,9 +87,9 @@ class DriveApiService:
upload_backup_job.start()
def _onUploadFinished(self, job: "UploadBackupJob") -> None:
if job.backup_upload_error_text != "":
if job.backup_upload_error_message != "":
# If the job contains an error message we pass it along so the UI can display it.
self.creatingStateChanged.emit(is_creating = False, error_message = job.backup_upload_error_text)
self.creatingStateChanged.emit(is_creating = False, error_message = job.backup_upload_error_message)
else:
self.creatingStateChanged.emit(is_creating = False)