3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Refactor out unnecesary late init (to make tests cleaner). [UnitTests]

Browse source
This commit is contained in:
Remco Burema 2018-11-16 16:53:37 +01:00
parent 3dd355976b
commit 69e2fa396e
2 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugins/FirmwareUpdateChecker/FirmwareUpdateCheckerJob.py
View file

@ -32,7 +32,7 @@ class FirmwareUpdateCheckerJob(Job):
self._machine_name = machine_name
self._metadata = metadata
self._lookups = None # type:Optional[FirmwareUpdateCheckerLookup]
self._lookups = FirmwareUpdateCheckerLookup(self._machine_name, self._metadata)
self._headers = {} # type:Dict[str, str] # Don't set headers yet.
def getUrlResponse(self, url: str) -> str:
@ -69,9 +69,6 @@ class FirmwareUpdateCheckerJob(Job):
return max_version
def run(self):
if self._lookups is None:
self._lookups = FirmwareUpdateCheckerLookup(self._machine_name, self._metadata)
try:
# Initialize a Preference that stores the last version checked for this printer.
Application.getInstance().getPreferences().addPreference(