3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-25 15:44:04 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Add test for constraining container types to certain slots

Browse source 
Only the definition slot must hold a definition container. All the rest must hold an instance container. This fails currently because the properties don't even exist.

Contributes to issue CURA-3497.
This commit is contained in:
Ghostkeeper 2017-03-24 17:32:33 +01:00
parent e3932cb21c
commit 69c53dcd73
No known key found for this signature in database
GPG key ID: C5F96EE2BC0F7E75
1 changed files with 38 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

39
tests/Settings/TestExtruderStack.py
View file

@ -8,8 +8,9 @@ import unittest.mock #For the mocking and monkeypatching functionality.
import UM.Settings.ContainerRegistry #To create empty instance containers. import UM.Settings.ContainerRegistry #To create empty instance containers.
import UM.Settings.ContainerStack #To set the container registry the container stacks use. import UM.Settings.ContainerStack #To set the container registry the container stacks use.
from UM.Settings.DefinitionContainer import DefinitionContainer #To check against the class of DefinitionContainer. from UM.Settings.DefinitionContainer import DefinitionContainer #To check against the class of DefinitionContainer.
from UM.Settings.InstanceContainer import InstanceContainer #To check against the class of InstanceContainer.
import cura.Settings.ExtruderStack #The module we're testing. import cura.Settings.ExtruderStack #The module we're testing.
from cura.Settings.Exceptions import InvalidOperationError #To check whether the correct exceptions are raised. from cura.Settings.Exceptions import InvalidContainerError, InvalidOperationError #To check whether the correct exceptions are raised.
## Fake container registry that always provides all containers you ask of. ## Fake container registry that always provides all containers you ask of.
@pytest.fixture() @pytest.fixture()
@ -48,6 +49,14 @@ def readStack(filename):
serialized = file_handle.read() serialized = file_handle.read()
return serialized return serialized
class DefinitionContainerSubClass(DefinitionContainer):
def __init__(self):
super().__init__(container_id = "SubDefinitionContainer")
class InstanceContainerSubClass(InstanceContainer):
def __init__(self):
super().__init__(container_id = "SubInstanceContainer")
#############################START OF TEST CASES################################ #############################START OF TEST CASES################################
## Tests whether adding a container is properly forbidden. ## Tests whether adding a container is properly forbidden.
@ -55,6 +64,34 @@ def test_addContainer(extruder_stack):
with pytest.raises(InvalidOperationError): with pytest.raises(InvalidOperationError):
extruder_stack.addContainer(unittest.mock.MagicMock()) extruder_stack.addContainer(unittest.mock.MagicMock())
## Tests whether the container types are properly enforced on the stack.
#
# When setting a field to have a different type of stack than intended, we
# should get an exception.
@pytest.mark.parametrize("definition_container, instance_container", [
(DefinitionContainer(container_id = "TestDefinitionContainer"), InstanceContainer(container_id = "TestInstanceContainer")),
(DefinitionContainerSubClass(), InstanceContainerSubClass())
])
def test_constrainContainerTypes(definition_container, instance_container, extruder_stack):
with pytest.raises(InvalidContainerError): #Putting a definition container in the user changes is not allowed.
extruder_stack.userChanges = definition_container
extruder_stack.userChanges = instance_container #Putting an instance container in the user changes is allowed.
with pytest.raises(InvalidContainerError):
extruder_stack.qualityChanges = definition_container
extruder_stack.qualityChanges = instance_container
with pytest.raises(InvalidContainerError):
extruder_stack.quality = definition_container
extruder_stack.quality = instance_container
with pytest.raises(InvalidContainerError):
extruder_stack.material = definition_container
extruder_stack.material = instance_container
with pytest.raises(InvalidContainerError):
extruder_stack.variant = definition_container
extruder_stack.variant = instance_container
with pytest.raises(InvalidContainerError): #Putting an instance container in the definition is not allowed.
extruder_stack.definition = instance_container
extruder_stack.definition = definition_container #Putting a definition container in the definition is allowed.
## Tests whether definitions are being read properly from an extruder stack. ## Tests whether definitions are being read properly from an extruder stack.
@pytest.mark.parametrize("filename, definition_id", [ @pytest.mark.parametrize("filename, definition_id", [
("Left.extruder.cfg", "empty"), ("Left.extruder.cfg", "empty"),