From 658e54c8e513366434aa8b5a8840ed92968b8d4a Mon Sep 17 00:00:00 2001 From: Konstantinos Karmas Date: Tue, 5 Oct 2021 11:36:10 +0200 Subject: [PATCH] Simplify the check for new materials If there is at least one material, we can already show the message without checking the rest of the installed packages. CURA-8254 --- cura/Machines/Models/MaterialManagementModel.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cura/Machines/Models/MaterialManagementModel.py b/cura/Machines/Models/MaterialManagementModel.py index 56315be86e..468d28709b 100644 --- a/cura/Machines/Models/MaterialManagementModel.py +++ b/cura/Machines/Models/MaterialManagementModel.py @@ -41,11 +41,11 @@ class MaterialManagementModel(QObject): a message prompting the user to sync the materials with their printers. """ application = cura.CuraApplication.CuraApplication.getInstance() - new_materials_installed = False - for package_id, package_info in application.getPackageManager().installed_packages.items(): - new_materials_installed = package_info["package_info"]["package_type"] == "material" - if new_materials_installed: - self._showSyncNewMaterialsMessage() + for package_id, package_data in application.getPackageManager().installed_packages.items(): + if package_data["package_info"]["package_type"] == "material": + # At least one new material was installed + self._showSyncNewMaterialsMessage() + break def _showSyncNewMaterialsMessage(self): sync_materials_message = Message(