From 62e7cb9a2dfc469e9fd095e47ce0554a689031f5 Mon Sep 17 00:00:00 2001 From: Ian Paschal Date: Tue, 27 Feb 2018 16:05:07 +0100 Subject: [PATCH 1/3] CURA-4972 Allow reslice after setting is removed The issue Andreea found was caused by the fact that the object was unsubscribed from setting validation while still having the illegal value, because the setting (and its illegal value) was removed AFTER unsubscribing. Thus the illegal value got "saved" until the next time you added that setting and set the correct value. --- plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml b/plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml index 11e4a9cd0e..4b5d2a5708 100644 --- a/plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml +++ b/plugins/PerObjectSettingsTool/PerObjectSettingsPanel.qml @@ -241,8 +241,8 @@ Item { height: UM.Theme.getSize("setting").height onClicked: { - UM.ActiveTool.triggerAction("unsubscribeForSettingValidation", model.key) addedSettingsModel.setVisible(model.key, false) + UM.ActiveTool.triggerAction("unsubscribeForSettingValidation", model.key) } style: ButtonStyle From a74282a66435fb433a9b0fc2f543ebef51ac38ae Mon Sep 17 00:00:00 2001 From: Ian Paschal Date: Wed, 28 Feb 2018 09:15:53 +0100 Subject: [PATCH 2/3] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index b78b9b91a2..d8e36d9729 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,9 +1,12 @@ From 1eaec2ecbc0c22a20879cc8c5fb36cf8b60e4932 Mon Sep 17 00:00:00 2001 From: Ian Paschal Date: Wed, 28 Feb 2018 09:17:11 +0100 Subject: [PATCH 3/3] Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index d8e36d9729..97c849144d 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,9 +1,9 @@