3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

FirmwareUpdateChecker: Small refactors due to code review.

Browse source
This commit is contained in:
Remco Burema 2018-10-13 19:21:22 +02:00
parent 1b7055f0f3
commit 60408c14bc
4 changed files with 27 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/FirmwareUpdateChecker/FirmwareUpdateCheckerJob.py
View file

@ -12,7 +12,7 @@ from urllib.error import URLError
from typing import Dict
import codecs
from .FirmwareUpdateCheckerLookup import FirmwareUpdateCheckerLookup, get_settings_key_for_machine
from .FirmwareUpdateCheckerLookup import FirmwareUpdateCheckerLookup, getSettingsKeyForMachine
from UM.i18n import i18nCatalog
i18n_catalog = i18nCatalog("cura")
@ -78,12 +78,12 @@ class FirmwareUpdateCheckerJob(Job):
# If it is not None, then we compare between the checked_version and the current_version
machine_id = self._lookups.getMachineByName(machine_name.lower())
if machine_id is not None:
Logger.log("i", "You have a {0} in the printer list. Let's check the firmware!".format(machine_name))
Logger.log("i", "You have a(n) {0} in the printer list. Let's check the firmware!".format(machine_name))
current_version = self.getCurrentVersionForMachine(machine_id)
# If it is the first time the version is checked, the checked_version is ""
setting_key_str = get_settings_key_for_machine(machine_id)
setting_key_str = getSettingsKeyForMachine(machine_id)
checked_version = Version(Application.getInstance().getPreferences().getValue(setting_key_str))
# If the checked_version is "", it's because is the first time we check firmware and in this case