Replace isProfileUserCreated with hasCustomQuality

CURA-6028

cura/Settings/MachineManager.py

@@ -1529,6 +1529,10 @@ class MachineManager(QObject):
     def activeQualityChangesGroup(self) -> Optional["QualityChangesGroup"]:
         return self._current_quality_changes_group
 
+    @pyqtProperty(bool, notify = activeQualityChangesGroupChanged)
+    def hasCustomQuality(self) -> bool:
+        return self._current_quality_changes_group is not None
+
     @pyqtProperty(str, notify = activeQualityGroupChanged)
     def activeQualityOrQualityChangesName(self) -> str:
         name = empty_quality_container.getName()

cura/Settings/SimpleModeSettingsManager.py

@@ -17,15 +17,11 @@ class SimpleModeSettingsManager(QObject):
         self._is_profile_user_created = False  # True when profile was custom created by user
 
         self._machine_manager.activeStackValueChanged.connect(self._updateIsProfileCustomized)
-        self._machine_manager.activeQualityGroupChanged.connect(self.updateIsProfileUserCreated)
-        self._machine_manager.activeQualityChangesGroupChanged.connect(self.updateIsProfileUserCreated)
 
         # update on create as the activeQualityChanged signal is emitted before this manager is created when Cura starts
         self._updateIsProfileCustomized()
-        self.updateIsProfileUserCreated()
 
     isProfileCustomizedChanged = pyqtSignal()
-    isProfileUserCreatedChanged = pyqtSignal()
 
     @pyqtProperty(bool, notify = isProfileCustomizedChanged)
     def isProfileCustomized(self):
@@ -58,34 +54,6 @@ class SimpleModeSettingsManager(QObject):
             self._is_profile_customized = has_customized_user_settings
             self.isProfileCustomizedChanged.emit()
 
-    @pyqtProperty(bool, notify = isProfileUserCreatedChanged)
-    def isProfileUserCreated(self):
-        return self._is_profile_user_created
-
-    @pyqtSlot()
-    def updateIsProfileUserCreated(self) -> None:
-        quality_changes_keys = set()  # type: Set[str]
-
-        if not self._machine_manager.activeMachine:
-            return
-
-        global_stack = self._machine_manager.activeMachine
-
-        # check quality changes settings in the global stack
-        quality_changes_keys.update(global_stack.qualityChanges.getAllKeys())
-
-        # check quality changes settings in the extruder stacks
-        if global_stack.extruders:
-            for extruder_stack in global_stack.extruders.values():
-                quality_changes_keys.update(extruder_stack.qualityChanges.getAllKeys())
-
-        # check if the qualityChanges container is not empty (meaning it is a user created profile)
-        has_quality_changes = len(quality_changes_keys) > 0
-
-        if has_quality_changes != self._is_profile_user_created:
-            self._is_profile_user_created = has_quality_changes
-            self.isProfileUserCreatedChanged.emit()
-
     # These are the settings included in the Simple ("Recommended") Mode, so only when the other settings have been
     # changed, we consider it as a user customized profile in the Simple ("Recommended") Mode.
     __ignored_custom_setting_keys = ["support_enable",

resources/qml/PrintSetupSelector/Recommended/RecommendedQualityProfileSelector.qml

@@ -39,17 +39,6 @@ Item
     {
         target: Cura.QualityProfilesDropDownMenuModel
         onItemsChanged: qualityModel.update()
-        onDataChanged:
-        {
-            // If a custom profile is selected and then a user decides to change any of setting the slider should show
-            // the reset button. After clicking the reset button the QualityProfilesDropDownMenuModel(ListModel) is
-            // updated before the property isProfileCustomized is called to update.
-            if (Cura.SimpleModeSettingsManager.isProfileCustomized)
-            {
-                Cura.SimpleModeSettingsManager.updateIsProfileUserCreated()
-            }
-            qualityModel.update()
-        }
     }
 
     Connections {
@@ -97,7 +86,7 @@ Item
                 if (Cura.MachineManager.activeQualityType == qualityItem.quality_type)
                 {
                     // set to -1 when switching to user created profile so all ticks are clickable
-                    if (Cura.SimpleModeSettingsManager.isProfileUserCreated)
+                    if (Cura.MachineManager.hasCustomQuality)
                     {
                         qualityModel.qualitySliderActiveIndex = -1
                     }
@@ -192,7 +181,7 @@ Item
         {
             id: customisedSettings
 
-            visible: Cura.SimpleModeSettingsManager.isProfileCustomized || Cura.SimpleModeSettingsManager.isProfileUserCreated
+            visible: Cura.SimpleModeSettingsManager.isProfileCustomized || Cura.MachineManager.hasCustomQuality
             height: visible ? UM.Theme.getSize("print_setup_icon").height : 0
             width: height
             anchors
@@ -358,7 +347,7 @@ Item
             {
                 anchors.fill: parent
                 hoverEnabled: true
-                enabled: !Cura.SimpleModeSettingsManager.isProfileUserCreated
+                enabled: !Cura.MachineManager.hasCustomQuality
                 onEntered:
                 {
                     var tooltipContent = catalog.i18nc("@tooltip", "This quality profile is not available for your current material and nozzle configuration. Please change these to enable this quality profile")
@@ -417,7 +406,7 @@ Item
                     implicitWidth: UM.Theme.getSize("print_setup_slider_handle").width
                     implicitHeight: implicitWidth
                     radius: Math.round(implicitWidth / 2)
-                    visible: !Cura.SimpleModeSettingsManager.isProfileCustomized && !Cura.SimpleModeSettingsManager.isProfileUserCreated && qualityModel.existingQualityProfile
+                    visible: !Cura.SimpleModeSettingsManager.isProfileCustomized && !Cura.MachineManager.hasCustomQuality && qualityModel.existingQualityProfile
                 }
             }
 
@@ -441,7 +430,7 @@ Item
                 anchors.fill: parent
                 hoverEnabled: true
                 acceptedButtons: Qt.NoButton
-                enabled: !Cura.SimpleModeSettingsManager.isProfileUserCreated
+                enabled: !Cura.MachineManager.hasCustomQuality
             }
         }
 
@@ -451,7 +440,7 @@ Item
         {
             anchors.fill: parent
             hoverEnabled: true
-            visible: Cura.SimpleModeSettingsManager.isProfileUserCreated
+            visible: Cura.MachineManager.hasCustomQuality
 
             onEntered:
             {